You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apache-bugdb@apache.org by John Van Essen <jv...@gamers.org> on 2000/11/15 10:57:43 UTC
mod_autoindex/6849: IndexOption {absolute} +{incremental} ignores incremental setting
>Number: 6849
>Category: mod_autoindex
>Synopsis: IndexOption {absolute} +{incremental} ignores incremental setting
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: apache
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: apache
>Arrival-Date: Wed Nov 15 02:00:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: jve@gamers.org
>Release: 1.3.12
>Organization:
apache
>Environment:
Linux, but it doesn't matter - the problem is in the code
>Description:
Bug in autoindex code - if there is an absolute setting (no +/- prefix),
then any accompanying +/- setting in that directory is totally ignored.
>How-To-Repeat:
IndexOptions FancyIndexing +SuppressColumnSorting
The SuppressColumnSorting setting will be ignored and the column headings
will still be hyperlinks.
>Fix:
Two lines of code seem to be missing in merge_autoindex_configs():
else {
/*
* There are local non-incremental settings, which clear
* all inheritance from above. They *are* the new base settings.
*/
new->opts = add->opts;;
}
The new->incremented_opts and new->decremented_opts values are left undefined
here (actually 0), whereas they should be copied from add:
new->incremented_opts = add->incremented_opts;
new->decremented_opts = add->decremented_opts;
I'm not sure if they should be merged with the old {inc,dec}remented_opts -
the presence of an absolute option would imply that any previous relative
changes should be thrown out, too, so I think the above code should suffice.
>Release-Note:
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <ap...@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or ]
["Re: general/1098:"). If the subject doesn't match this ]
[pattern, your message will be misfiled and ignored. The ]
["apbugs" address is not added to the Cc line of messages from ]
[the database automatically because of the potential for mail ]
[loops. If you do not include this Cc, your reply may be ig- ]
[nored unless you are responding to an explicit request from a ]
[developer. Reply only with text; DO NOT SEND ATTACHMENTS! ]