You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/09 12:27:04 UTC
[GitHub] [flink] XComp opened a new pull request, #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
XComp opened a new pull request, #21478:
URL: https://github.com/apache/flink/pull/21478
## What is the purpose of the change
These tests cause constant test instabilities. We decided to disable these tests for now to reduce the amount of effort for CI maintenance. FLINK-30351 was created to cover the re-enabling the tests.
## Brief change log
* added `@Disabled` annotation to the aforementioned tests
## Verifying this change
Check the CI run manually whether the tests are actually disabled
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #21478:
URL: https://github.com/apache/flink/pull/21478#discussion_r1044619071
##########
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarUnorderedSourceITCase.java:
##########
@@ -32,12 +32,14 @@
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.pulsar.client.api.SubscriptionType;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
/**
* Unit test class for {@link PulsarSource}. Used for {@link SubscriptionType#Shared} subscription.
*/
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
+@Disabled("FLINK-28352")
Review Comment:
I guess, both are fine. I decided to go for the parent issue because it also includes the subtasks. But reiterating over it: You might be right because FLINK-30351 actually mentions all the subtasks that need to be resolved before removing the annotations again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21478:
URL: https://github.com/apache/flink/pull/21478#issuecomment-1362512313
Closing this one in favor of PR #21501 where we remove the pulsar-related code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #21478:
URL: https://github.com/apache/flink/pull/21478#discussion_r1044526123
##########
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarUnorderedSourceITCase.java:
##########
@@ -32,12 +32,14 @@
import org.apache.flink.streaming.api.CheckpointingMode;
import org.apache.pulsar.client.api.SubscriptionType;
+import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
/**
* Unit test class for {@link PulsarSource}. Used for {@link SubscriptionType#Shared} subscription.
*/
@Tag("org.apache.flink.testutils.junit.FailsOnJava11")
+@Disabled("FLINK-28352")
Review Comment:
Just asking: shouldn't it refer to FLINK-30351 where in theory it should be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21478:
URL: https://github.com/apache/flink/pull/21478#issuecomment-1344252801
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fdf3b41711c4f857d2b21fdbf96c1057f3b7811",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fdf3b41711c4f857d2b21fdbf96c1057f3b7811",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fdf3b41711c4f857d2b21fdbf96c1057f3b7811 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp closed pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
Posted by GitBox <gi...@apache.org>.
XComp closed pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase
URL: https://github.com/apache/flink/pull/21478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org