[PR] ci: run Iceberg Spark tests on all PRs and commits to main branch [datafusion-comet]

["mbutrovich (via GitHub)" <gi...@apache.org>]

mbutrovich opened a new pull request, #3792:
URL: https://github.com/apache/datafusion-comet/pull/3792

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   N/A.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   We currently only run Iceberg Spark tests when a PR has `[iceberg]` in the title. However, we've had several PRs merge in the last few weeks that silently broke the Iceberg support because we didn't anticipate changes interacting with the Iceberg code path. We should always run Iceberg Spark tests on all PRs and commits to `main`.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   1. Remove `if: contains(github.event.pull_request.title, '[iceberg]')` from all jobs in `iceberg_spark_test.yml`
   2. Rename `dev/diffs/iceberg-rust/` to `dev/diffs/iceberg/`
   3. Delete unused `.github/actions/setup-iceberg-builder/` action, rename `.github/actions/setup-iceberg-rust-builder/` to `.github/actions/setup-iceberg-builder/`, update diff path and workflow references
   4. Add `Iceberg Spark Tests <iceberg-spark-tests.md>` to contributor guide index
   5. Update `iceberg-spark-tests.md`: replace `iceberg-rust` paths with `iceberg`, update CI trigger description
   
   ## How are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   Existing tests, just run unconditionally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] ci: run Iceberg Spark tests on all PRs and commits to main branch [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove merged PR #3792:
URL: https://github.com/apache/datafusion-comet/pull/3792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org