You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "klsince (via GitHub)" <gi...@apache.org> on 2023/06/12 18:30:15 UTC
[GitHub] [pinot] klsince opened a new pull request, #10898: bump awssdk version for a bugfix on http conn leakage
klsince opened a new pull request, #10898:
URL: https://github.com/apache/pinot/pull/10898
`bugfix`
The latest aws sdk version 2.20.83 includes a critical bugfix https://github.com/aws/aws-sdk-java-v2/pull/4066 to avoid http conn leakage when aws requests, like S3 getObject, get interrupted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #10898: bump awssdk version for a bugfix on http conn leakage
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince commented on code in PR #10898:
URL: https://github.com/apache/pinot/pull/10898#discussion_r1227506577
##########
pinot-plugins/pinot-file-system/pinot-s3/pom.xml:
##########
@@ -183,27 +183,9 @@
</dependency>
<dependency>
<groupId>com.adobe.testing</groupId>
- <artifactId>s3mock-testng</artifactId>
+ <artifactId>s3mock-testcontainers</artifactId>
Review Comment:
`s3mock-testcontainers` is [recommended](https://github.com/adobe/S3Mock#s3mock-java) as it avoids bring in deps from s3mock transitively, which brings in the spring framework and also requires some [specific keystore](https://github.com/adobe/S3Mock/issues/720).
The new version of s3mock is more accurate on handling the leading and trailing slash in s3 object names, so the changes on the unit tests as made in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr merged pull request #10898: bump awssdk version for a bugfix on http conn leakage
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #10898:
URL: https://github.com/apache/pinot/pull/10898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on pull request #10898: bump awssdk version for a bugfix on http conn leakage
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince commented on PR #10898:
URL: https://github.com/apache/pinot/pull/10898#issuecomment-1587895728
> can't we extract the aws.sdk.version somewhere less verbose
I'll let the PR pass tests and then polish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10898: bump awssdk version for a bugfix on http conn leakage
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10898:
URL: https://github.com/apache/pinot/pull/10898#issuecomment-1587940008
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10898](https://app.codecov.io/gh/apache/pinot/pull/10898?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (86ae279) into [master](https://app.codecov.io/gh/apache/pinot/commit/24b50ed65f5ff1405479cd4136fda85ffa99f9c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (24b50ed) will **decrease** coverage by `70.23%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 86ae279 differs from pull request most recent head d63ca52. Consider uploading reports for the commit d63ca52 to get more accurate results
```diff
@@ Coverage Diff @@
## master #10898 +/- ##
=============================================
- Coverage 70.22% 0.00% -70.23%
=============================================
Files 2174 1650 -524
Lines 116871 86162 -30709
Branches 17702 13570 -4132
=============================================
- Hits 82078 0 -82078
- Misses 29058 86162 +57104
+ Partials 5735 0 -5735
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests1temurin11 | `0.00% <ø> (?)` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2077 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10898/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #10898: bump awssdk version for a bugfix on http conn leakage
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #10898:
URL: https://github.com/apache/pinot/pull/10898#issuecomment-1588111822
error seems related to the s3mock package with the latest aws lib:
```
Tests run: 17, Failures: 1, Errors: 0, Skipped: 16, Time elapsed: 7.534 s <<< FAILURE! - in org.apache.pinot.plugin.filesystem.S3PinotFSTest
Error: org.apache.pinot.plugin.filesystem.S3PinotFSTest.setUp Time elapsed: 7.309 s <<< FAILURE!
software.amazon.awssdk.services.s3.model.S3Exception: null (Service: S3, Status Code: 405, Request ID: null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org