Re: [PR] [Spark] Implement Purge table for SparkCatalog [paimon]

["zhujing1-ola (via GitHub)" <gi...@apache.org>]

zhujing1-ola commented on code in PR #3015:
URL: https://github.com/apache/paimon/pull/3015#discussion_r1544428886


##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -173,6 +173,12 @@ public List<String> listTables(String databaseName) throws DatabaseNotExistExcep
     @Override
     public void dropTable(Identifier identifier, boolean ignoreIfNotExists)
             throws TableNotExistException {
+        dropTable(identifier, ignoreIfNotExists, false);

Review Comment:
   already add some tests for it



##########
paimon-spark/paimon-spark-3.1/src/test/java/org/apache/paimon/spark/SparkGenericCatalogTest.java:
##########
@@ -105,6 +107,42 @@ public void testCsvTable() {
                 .containsExactlyInAnyOrder("[1,2,3]", "[4,5,6]");
     }
 
+    @Test

Review Comment:
   already moved to DDLTestBase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org