You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/11/29 12:06:34 UTC

[GitHub] [hudi] shenh062326 commented on a change in pull request #2278: [HUDI-1412] Make HoodieWriteConfig support setting different default …

shenh062326 commented on a change in pull request #2278:
URL: https://github.com/apache/hudi/pull/2278#discussion_r532200190



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -278,5 +299,16 @@ public HoodieIndexConfig build() {
       HoodieIndex.IndexType.valueOf(props.getProperty(INDEX_TYPE_PROP));
       return config;
     }
+
+    private String getDefaultIndexType(EngineType engineType) {
+      switch (engineType) {

Review comment:
       Are there other configurations that are different in different engines, and if there are many, are they easy to implement in this way?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org