[jira] [Created] (HBASE-24813) ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination

["Wellington Chevreuil (Jira)" <ji...@apache.org>]

Wellington Chevreuil created HBASE-24813:
--------------------------------------------

             Summary: ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination
                 Key: HBASE-24813
                 URL: https://issues.apache.org/jira/browse/HBASE-24813
             Project: HBase
          Issue Type: Bug
            Reporter: Wellington Chevreuil
            Assignee: Wellington Chevreuil


Following investigations on the issue described by [~elserj] on HBASE-24779, we found out that once a peer is removed, thus killing peers related *ReplicationSource* instance, it may leave *ReplicationSourceManager.totalBufferUsed* inconsistent. This can happen if *ReplicationSourceWALReader* had put some entries on its queue to be processed by *ReplicationSourceShipper,* but the peer removal killed the shipper before it could process the pending entries. When *ReplicationSourceWALReader* thread add entries to the queue, it increments *ReplicationSourceManager.totalBufferUsed* with the sum of the entries sizes. When those entries are read by *ReplicationSourceShipper,* *ReplicationSourceManager.totalBufferUsed* is then decreased. We should also decrease *ReplicationSourceManager.totalBufferUsed* when *ReplicationSource* is terminated, otherwise those unprocessed entries size would be consuming *ReplicationSourceManager.totalBufferUsed __*indefinitely, unless the RS gets restarted. This may be a problem for deployments with multiple peers, or if new peers are added.**



--
This message was sent by Atlassian Jira
(v8.3.4#803005)