[GitHub] [incubator-nemo] johnyangk commented on a change in pull request #238: [NEMO-418] BlockFetchFailureProperty

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #238: [NEMO-418] BlockFetchFailureProperty
URL: https://github.com/apache/incubator-nemo/pull/238#discussion_r327435221
 
 

 ##########
 File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/annotating/TransientResourceDataTransferPass.java
 ##########
 @@ -79,10 +83,12 @@ static boolean fromTransientToReserved(final IREdge irEdge) {
    * @param irEdge edge to check.
    * @return whether or not the edge satisfies the condition.
    */
-  static boolean fromReservedToTransient(final IREdge irEdge) {
-    return ResourcePriorityProperty.RESERVED
-      .equals(irEdge.getSrc().getPropertyValue(ResourcePriorityProperty.class).get())
-      && ResourcePriorityProperty.TRANSIENT
-      .equals(irEdge.getDst().getPropertyValue(ResourcePriorityProperty.class).get());
+  private boolean fromReservedToTransient(final IREdge irEdge) {
+    return ResourcePriorityProperty.RESERVED.equals(getResourcePriority(irEdge.getSrc()))
+      && ResourcePriorityProperty.TRANSIENT.equals(getResourcePriority(irEdge.getDst()));
+  }
+
+  private String getResourcePriority(final IRVertex irVertex) {
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services