You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/11 02:47:01 UTC

[GitHub] [cordova-plugin-inappbrowser] isdh opened a new pull request #723: fix(ios): apply PR#672 to uiwebview.

isdh opened a new pull request #723:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/723


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   I need to use uiwebview on iOS13. In spite of designate landscape mode only, StatusBar somehow orientate as portrait.
   but #672 didn't apply to uiwebview. And removed uiwebview on 4.0.x branch.
   
   ### Description
   <!-- Describe your changes in detail -->
   apply [#672](https://github.com/apache/cordova-plugin-inappbrowser/pull/672) to uiwebview.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] jcesarmobile closed pull request #723: fix(ios): apply PR#672 to uiwebview.

Posted by GitBox <gi...@apache.org>.
jcesarmobile closed pull request #723:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/723


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on pull request #723: fix(ios): apply PR#672 to uiwebview.

Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #723:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/723#issuecomment-644094496


   thanks for the PR, but we don't apply fixes to old versions of plugins, only in the case of security problems, if you need that fix you can create a fork and maintain it for yourself.
   Also, UIWebView is deprecated and Apple doesn't allow to use it in new apps since April and won't allow it in existing apps in December, so you should not use it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-plugin-inappbrowser] isdh commented on pull request #723: fix(ios): apply PR#672 to uiwebview.

Posted by GitBox <gi...@apache.org>.
isdh commented on pull request #723:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/723#issuecomment-645101298


   @jcesarmobile 
   OK. thanks for comment. I'll maintain this fix in my repository.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org