[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request #385: HDDS-2779. Fix list volume for --start parameter

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #385: HDDS-2779. Fix list volume for --start parameter
URL: https://github.com/apache/hadoop-ozone/pull/385#discussion_r360690535
 
 

 ##########
 File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java
 ##########
 @@ -299,11 +299,6 @@ public URI getKeyProviderUri() throws IOException {
 
     @Override
     public boolean hasNext() {
-      if(!currentIterator.hasNext()) {
-        currentIterator = getNextListOfVolumes(
-            currentValue != null ? currentValue.getName() : null)
-            .iterator();
-      }
 
 Review comment:
   Without this logic, remote iteration will not work. Removing this will break the `listVolume` call if we try to list more than 1000 (`ozone.client.list.cache` ) volumes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org