You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by we...@apache.org on 2022/12/21 08:22:09 UTC

[dolphinscheduler] branch dev updated: fix spell error and move comment to correct describe location (#13233)

This is an automated email from the ASF dual-hosted git repository.

wenjun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new d13cd55281 fix spell error and move comment to correct describe location (#13233)
d13cd55281 is described below

commit d13cd55281e1758613fccb5199334e5415bdf0db
Author: ZhongJinHacker <ji...@hotmail.com>
AuthorDate: Wed Dec 21 16:22:03 2022 +0800

    fix spell error and move comment to correct describe location (#13233)
---
 .../dolphinscheduler/server/master/event/WorkflowStartEventHandler.java | 2 +-
 .../dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java
index 13d82f0671..b66c972ed6 100644
--- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java
+++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/WorkflowStartEventHandler.java
@@ -63,12 +63,12 @@ public class WorkflowStartEventHandler implements WorkflowEventHandler {
         CompletableFuture.supplyAsync(workflowExecuteRunnable::call, workflowExecuteThreadPool)
                 .thenAccept(workflowSubmitStatue -> {
                     if (WorkflowSubmitStatue.SUCCESS == workflowSubmitStatue) {
-                        // submit failed will resend the event to workflow event queue
                         logger.info("Success submit the workflow instance");
                         if (processInstance.getTimeout() > 0) {
                             stateWheelExecuteThread.addProcess4TimeoutCheck(processInstance);
                         }
                     } else {
+                        // submit failed will resend the event to workflow event queue
                         logger.error("Failed to submit the workflow instance, will resend the workflow start event: {}",
                                 workflowEvent);
                         workflowEventQueue.addEvent(workflowEvent);
diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
index cd6967cf10..5ee3bb957f 100644
--- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
+++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
@@ -991,7 +991,7 @@ public class WorkflowExecuteRunnable implements Callable<WorkflowSubmitStatue> {
 
             // if we use task group, then need to acquire the task group resource
             // if there is no resource the current task instance will not be dispatched
-            // it will be weakup when other tasks release the resource.
+            // it will be wakeup when other tasks release the resource.
             int taskGroupId = taskInstance.getTaskGroupId();
             if (taskGroupId > 0) {
                 boolean acquireTaskGroup = processService.acquireTaskGroup(taskInstance.getId(),