You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2011/04/12 00:25:06 UTC
[jira] [Resolved] (CASSANDRA-1515) refactoring re-used code in
CassandraServer classes into a common superclass.
[ https://issues.apache.org/jira/browse/CASSANDRA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1515.
---------------------------------------
Resolution: Not A Problem
Avro was removed for 0.8
> refactoring re-used code in CassandraServer classes into a common superclass.
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-1515
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1515
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Amol Deshpande
> Priority: Minor
> Attachments: get_insert.diff.txt
>
>
> This is my first attempt at refactoring common code between avro and thrift CassandraServer classes into a common superclass.
> (It's not fully tested yet, but I did create and query a simple keyspace with cassandra-cli. Looking for feedback about the direction at this point rather than commit to repository).
> Here is the broad outline:
> 1. A new class called AbstractCassandraServer that implements get() and insert() for now.
> 2. Specialized CassandraServer...Exception() classes thrown by StorageProxy, instead of re-using thrift exceptions.
> As I progress in this refactoring, I'd like to do the following :
> 3. move validation fully into a shared class rather than avro and thrift doing validation.
> 4. Change batch_mutate so that it does not have avro/thrift versions.
> As well as any other work along the way that will make the client-facing interfaces independent of the RPC protocol.
> thanks!
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira