You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Richard Emberson (JIRA)" <ji...@apache.org> on 2010/11/30 16:30:11 UTC
[jira] Created: (WICKET-3208) MicroMapTest.java tests map's size 3
times rather than keySet, entrySet, values size
MicroMapTest.java tests map's size 3 times rather than keySet, entrySet, values size
------------------------------------------------------------------------------------
Key: WICKET-3208
URL: https://issues.apache.org/jira/browse/WICKET-3208
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5-M3
Environment: all
Reporter: Richard Emberson
Priority: Trivial
In the MicroMapTest testMicroMap test, the MicroMap's size is tested 3 times rather
than testing the keySet's, entrySet's and values' sizes.
Lines 45, 64 and 84 should be changed from:
assertEquals(1, m.size());
to
assertEquals(1, s.size());
assertEquals(1, s.size());
assertEquals(1, v.size());
respectfully.
No big deal. I was swapping out the MicroMap and noticed the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3208) MicroMapTest.java tests map's size 3
times rather than keySet, entrySet, values size
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3208.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
Assignee: Igor Vaynberg
added the extra checks. the old size checks are also valid.
> MicroMapTest.java tests map's size 3 times rather than keySet, entrySet, values size
> ------------------------------------------------------------------------------------
>
> Key: WICKET-3208
> URL: https://issues.apache.org/jira/browse/WICKET-3208
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Environment: all
> Reporter: Richard Emberson
> Assignee: Igor Vaynberg
> Priority: Trivial
> Fix For: 1.5-M4
>
>
> In the MicroMapTest testMicroMap test, the MicroMap's size is tested 3 times rather
> than testing the keySet's, entrySet's and values' sizes.
> Lines 45, 64 and 84 should be changed from:
> assertEquals(1, m.size());
> to
> assertEquals(1, s.size());
> assertEquals(1, s.size());
> assertEquals(1, v.size());
> respectfully.
> No big deal. I was swapping out the MicroMap and noticed the bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.