You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/09 13:43:30 UTC
[GitHub] [apisix] spacewander opened a new pull request #5030: change: use a new name to customize lua_shared_dict in nginx.conf
spacewander opened a new pull request #5030:
URL: https://github.com/apache/apisix/pull/5030
The previous name is easy to mess up with another "lua_shared_dict"
configuration.
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5030: change: use a new name to customize lua_shared_dict in nginx.conf
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5030:
URL: https://github.com/apache/apisix/pull/5030#discussion_r706983107
##########
File path: apisix/cli/ops.lua
##########
@@ -265,7 +265,7 @@ local config_schema = {
http = {
type = "object",
properties = {
- lua_shared_dicts = {
+ custom_lua_shared_dict = {
Review comment:
lua_shared_dicts is still available now (only a warn message will generate).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #5030: change: use a new name to customize lua_shared_dict in nginx.conf
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #5030:
URL: https://github.com/apache/apisix/pull/5030#discussion_r705821663
##########
File path: apisix/cli/ops.lua
##########
@@ -750,6 +750,11 @@ Please modify "admin_key" in conf/config.yaml .
sys_conf["worker_processes"] = floor(tonumber(env_worker_processes))
end
+ if sys_conf["http"]["lua_shared_dicts"] then
+ stderr:write("lua_shared_dicts is deprecated, " ..
+ "custom_lua_shared_dict instead\n")
Review comment:
```suggestion
"use custom_lua_shared_dict instead\n")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] lilien1010 commented on a change in pull request #5030: change: use a new name to customize lua_shared_dict in nginx.conf
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #5030:
URL: https://github.com/apache/apisix/pull/5030#discussion_r706979154
##########
File path: apisix/cli/ops.lua
##########
@@ -265,7 +265,7 @@ local config_schema = {
http = {
type = "object",
properties = {
- lua_shared_dicts = {
+ custom_lua_shared_dict = {
Review comment:
will this impact the users upgrade from old version of APISIX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5030: change: use a new name to customize lua_shared_dict in nginx.conf
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5030:
URL: https://github.com/apache/apisix/pull/5030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org