You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/12 06:41:57 UTC

[GitHub] [flink] zhuzhurk commented on pull request #21621: [FLINK-30601][runtime] Omit "setKeyContextElement" call for non-keyed stream/operators to improve performance

zhuzhurk commented on PR #21621:
URL: https://github.com/apache/flink/pull/21621#issuecomment-1379880157

   Sorry that we missed something, that it changes the `@PublicEvolving` `AbstractStreamOperator` to implement an `@Internal` `KeyContextHandler`. This is not correct.
   
   I had an offline discussion with @wanglijie95, a potential problem is that when a user implemented an operator which overrides `AbstractStreamOperator#setKeyContextElement` and maintains different key selectors on its own, the change would result in incompatibility. This should rarely happen, but is possible because Flink offers this ability via public interface.
   
   Therefore, we decide to open a FLIP to the community and have a discussion on it, to avoid making the change silently.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org