[jira] [Work stopped] (KAFKA-4716) Fix logic for re-checking if internal topic is ready

["Eno Thereska (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on KAFKA-4716 stopped by Eno Thereska.
-------------------------------------------
> Fix logic for re-checking if internal topic is ready
> ----------------------------------------------------
>
>                 Key: KAFKA-4716
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4716
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.2.0
>            Reporter: Eno Thereska
>            Assignee: Eno Thereska
>            Priority: Blocker
>              Labels: architecture
>             Fix For: 0.10.2.0
>
>
> In InternalTopicManager, we have a hardcoded constant MAX_TOPIC_READY_TRY that is set to 5. We shouldn't hardcode the retry time and it should be based on a timeout, not on a number of retries.
> There are cases when the code in makeReady tries to create a topic but then fails because the controller is currently in transition and we get a warning: " Could not create internal topics: Could not create topic: <topic name> due to This is not the correct controller for this cluster." The code proceeds to retry MAX_TOPIC_READY_TRY times in a tight loop, and eventually fails. We should have a retry backoff (perhaps just use retry.backoff.ms) and a timeout (perhaps just use request.timeout.ms) instead of a number of retries.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)