You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/19 08:09:51 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #30424: [SPARK-33483][INFRA][TESTS] Fix rat exclusion patterns and add a LICENSE
dongjoon-hyun opened a new pull request #30424:
URL: https://github.com/apache/spark/pull/30424
### What changes were proposed in this pull request?
This PR fixes the RAT exclusion rule which was originated from SPARK-1144 (Apache Spark 1.0)
### Why are the changes needed?
This prevents the situation like https://github.com/apache/spark/pull/30415.
Currently, it missed `catalog` directory due to `.log` rule.
```
$ dev/check-license
Could not find Apache license headers in the following files:
!????? /Users/dongjoon/APACHE/spark-merge/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/MetadataColumn.java
!????? /Users/dongjoon/APACHE/spark-merge/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsMetadataColumns.java
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CI with the new rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730241367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730330780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730286206
Merged to branch-3.0. All related tests passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730330780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730451473
Thank you for merging, @HyukjinKwon !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730241337
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35933/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730207632
**[Test build #131332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131332/testReport)** for PR 30424 at commit [`8ac37df`](https://github.com/apache/spark/commit/8ac37dfd2885746b2a12ff434f08b2d3593043dd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730207987
Thank you, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30424:
URL: https://github.com/apache/spark/pull/30424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730229034
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35933/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730241367
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730241380
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35933/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730329370
**[Test build #131332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131332/testReport)** for PR 30424 at commit [`8ac37df`](https://github.com/apache/spark/commit/8ac37dfd2885746b2a12ff434f08b2d3593043dd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30424: [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30424:
URL: https://github.com/apache/spark/pull/30424#issuecomment-730207632
**[Test build #131332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131332/testReport)** for PR 30424 at commit [`8ac37df`](https://github.com/apache/spark/commit/8ac37dfd2885746b2a12ff434f08b2d3593043dd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org