You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ShadowySpirits (via GitHub)" <gi...@apache.org> on 2023/03/23 09:25:01 UTC
[GitHub] [rocketmq] ShadowySpirits opened a new pull request, #6455: [ISSUE #6454] Fix unsafe shutdown process in tiered storage
ShadowySpirits opened a new pull request, #6455:
URL: https://github.com/apache/rocketmq/pull/6455
fix #6454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6455: [ISSUE #6454] Fix unsafe shutdown process in tiered storage
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6455:
URL: https://github.com/apache/rocketmq/pull/6455#issuecomment-1480924050
## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6455](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7b70f3) into [develop](https://codecov.io/gh/apache/rocketmq/commit/3db8d039d18ba682f85985534df82250ab1b9fa8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3db8d03) will **increase** coverage by `0.19%`.
> The diff coverage is `38.73%`.
```diff
@@ Coverage Diff @@
## develop #6455 +/- ##
=============================================
+ Coverage 42.99% 43.18% +0.19%
- Complexity 8892 8954 +62
=============================================
Files 1103 1105 +2
Lines 77839 78075 +236
Branches 10134 10166 +32
=============================================
+ Hits 33466 33720 +254
+ Misses 40179 40130 -49
- Partials 4194 4225 +31
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/rocketmq/broker/out/BrokerOuterAPI.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb3V0L0Jyb2tlck91dGVyQVBJLmphdmE=) | `16.15% <0.00%> (+0.07%)` | :arrow_up: |
| [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | `25.27% <0.00%> (-0.02%)` | :arrow_down: |
| [.../apache/rocketmq/controller/ControllerManager.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9Db250cm9sbGVyTWFuYWdlci5qYXZh) | `47.68% <0.00%> (-0.87%)` | :arrow_down: |
| [...emoting/protocol/body/ElectMasterResponseBody.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2JvZHkvRWxlY3RNYXN0ZXJSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../remoting/protocol/body/RoleChangeNotifyEntry.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2JvZHkvUm9sZUNoYW5nZU5vdGlmeUVudHJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...l/header/controller/ElectMasterResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9jb250cm9sbGVyL0VsZWN0TWFzdGVyUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../apache/rocketmq/tieredstore/TieredDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL1RpZXJlZERpc3BhdGNoZXIuamF2YQ==) | `45.35% <40.00%> (+0.35%)` | :arrow_up: |
| [.../tieredstore/container/TieredContainerManager.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2NvbnRhaW5lci9UaWVyZWRDb250YWluZXJNYW5hZ2VyLmphdmE=) | `52.48% <42.85%> (+5.67%)` | :arrow_up: |
| [...he/rocketmq/broker/controller/ReplicasManager.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY29udHJvbGxlci9SZXBsaWNhc01hbmFnZXIuamF2YQ==) | `45.78% <45.45%> (+1.23%)` | :arrow_up: |
| [...ocketmq/tieredstore/container/TieredIndexFile.java](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2NvbnRhaW5lci9UaWVyZWRJbmRleEZpbGUuamF2YQ==) | `67.67% <50.00%> (+0.43%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/rocketmq/pull/6455?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [60 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-code-scanning[bot] commented on pull request #6455: [ISSUE #6454] Fix unsafe shutdown process in tiered storage
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on PR #6455:
URL: https://github.com/apache/rocketmq/pull/6455#issuecomment-1480878368
You have successfully added a new CodeQL configuration `.github/workflows/codeql_analysis.yml:CodeQL-Build`. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository [Security tab](/apache/rocketmq/security/code-scanning?query=pr%3A6455+tool%3ACodeQL+is%3Aopen) to see all alerts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #6455: [ISSUE #6454] Fix unsafe shutdown process in tiered storage
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui merged PR #6455:
URL: https://github.com/apache/rocketmq/pull/6455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org