You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/05/22 19:31:47 UTC
[GitHub] [trafficserver] jbfavre opened a new pull request, #8859: Re-introduce import to get man_pages list available for sphinx.
jbfavre opened a new pull request, #8859:
URL: https://github.com/apache/trafficserver/pull/8859
As explain in #8858, current man pages generation is broken.
Re-introducing the import fixes it.
Error has been introduced in commit 005b04bfbaa0381ccf214e4f781f6bf402426de0
Closes #8858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
bneradt merged PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#issuecomment-1137853823
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jbfavre commented on pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
jbfavre commented on PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#issuecomment-1134830057
> Thank you for working on this.
You're welcomed.
Always happy to help :wink:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#issuecomment-1134881351
I noticed that the autest failed in remap_reload. I've filed an issue to track that test's failure:
https://github.com/apache/trafficserver/issues/8860
Once the test complete's, I'll re-run autest CI for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#issuecomment-1134824237
Thank you for working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
randall commented on PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#issuecomment-1135051495
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
bneradt commented on code in PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#discussion_r879586346
##########
doc/conf.py:
##########
@@ -38,6 +38,10 @@
import os
from datetime import date
from sphinx import version_info
+# Import man_pages from manapges.py to get the list of manpages to generate in
+# separate files. Default is to put everything in apachetraffiserver.1
+# This import is required and acctualy used.
Review Comment:
acctualy -> actually
##########
doc/conf.py:
##########
@@ -38,6 +38,10 @@
import os
from datetime import date
from sphinx import version_info
+# Import man_pages from manapges.py to get the list of manpages to generate in
Review Comment:
manapges.py -> manpages.py
##########
doc/conf.py:
##########
@@ -38,6 +38,10 @@
import os
from datetime import date
from sphinx import version_info
+# Import man_pages from manapges.py to get the list of manpages to generate in
+# separate files. Default is to put everything in apachetraffiserver.1
Review Comment:
traffiserver -> trafficserver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
bneradt commented on code in PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#discussion_r879591982
##########
doc/conf.py:
##########
@@ -38,6 +38,10 @@
import os
from datetime import date
from sphinx import version_info
+# Import man_pages from manapges.py to get the list of manpages to generate in
+# separate files. Default is to put everything in apachetraffiserver.1
+# This import is required and acctualy used.
Review Comment:
I suggest:
```
For these reasons, despite what linting tools might say, this import is required.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8859: Re-introduce import to get man_pages list available for sphinx.
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8859:
URL: https://github.com/apache/trafficserver/pull/8859#issuecomment-1134913108
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org