You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Created) (JIRA)" <ji...@apache.org> on 2011/11/23 00:20:40 UTC

[jira] [Created] (THRIFT-1435) make TException.Message property conformant to the usual expectations

make TException.Message property conformant to the usual expectations
---------------------------------------------------------------------

                 Key: THRIFT-1435
                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
             Project: Thrift
          Issue Type: Improvement
          Components: Delphi - Compiler, Delphi - Library
    Affects Versions: 0.8
            Reporter: Jens Geyer


In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Kenjiro Fukumitsu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155807#comment-13155807 ] 

Kenjiro Fukumitsu commented on THRIFT-1435:
-------------------------------------------

Nice improvement, now you can see exception message in debugger. +1.

                
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Jake Farrell (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1435.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8
         Assignee: Jens Geyer

Committed
                
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.8
>
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155902#comment-13155902 ] 

Hudson commented on THRIFT-1435:
--------------------------------

Integrated in Thrift #340 (See [https://builds.apache.org/job/Thrift/340/])
    Thrift-1435: make TException.Message property conformant to the usual expectations
Client: delphi
Patch: Jens Geyer

Make delphi exceptions act like standard TException within other languages

                
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.8
>
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Jens Geyer (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155559#comment-13155559 ] 

Jens Geyer edited comment on THRIFT-1435 at 11/22/11 11:28 PM:
---------------------------------------------------------------

Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, should be called when setup of the exception object is complete (exception factory does this automatically)
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException

(Patch tested on Ubuntu 11.10 against Trunk)
                
      was (Author: jensg):
    Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, shpudl be called when setup of the exception object is complete (exception factory does this automatically)
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException

(Patch tested on Ubuntu 11.10 against Trunk)
                  
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1435:
-------------------------------

    Attachment: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch

Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, to be called when setup of the exception object has finished
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException
                
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Jens Geyer (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155559#comment-13155559 ] 

Jens Geyer edited comment on THRIFT-1435 at 11/22/11 11:26 PM:
---------------------------------------------------------------

Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, shpudl be called when setup of the exception object is complete (exception factory does this automatically)
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException
                
      was (Author: jensg):
    Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, to be called when setup of the exception object has finished
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException
                  
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (THRIFT-1435) make TException.Message property conformant to the usual expectations

Posted by "Jens Geyer (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155559#comment-13155559 ] 

Jens Geyer edited comment on THRIFT-1435 at 11/22/11 11:27 PM:
---------------------------------------------------------------

Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, shpudl be called when setup of the exception object is complete (exception factory does this automatically)
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException

(Patch tested on Ubuntu 11.10 against Trunk)
                
      was (Author: jensg):
    Patch:
- Library: procedure TException.Message made a function, allows reads, but still prevents writes
- Library: new method UpdateMessageProperty added, shpudl be called when setup of the exception object is complete (exception factory does this automatically)
- CodeGen: toString()-support added for Exception objects
- CodeGen: call to UpdateMessageProperty added in the Exception factory method CreateException
                  
> make TException.Message property conformant to the usual expectations
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-1435
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1435
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Compiler, Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1435_make_TException.Message_property_conformant_to_the_usual_expectations.patch
>
>
> In Delphi, Exceptions are expected to return a suitable error message when e.message is being read. In contrast, all Thrift TExceptions did not support this standard behaviour very well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira