You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2025/07/15 17:39:47 UTC
[PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
nvazquez opened a new pull request, #11207:
URL: https://github.com/apache/cloudstack/pull/11207
### Description
This PR restores the previous behavior on the Deploy VM view to select the first available template listed (has now changed on main branch)
Before the fix:
<img width="957" height="453" alt="Screenshot 2025-07-15 at 14 36 34" src="https://github.com/user-attachments/assets/32b9a2df-6773-47e4-a31b-a019a0ae798f" />
After the fix:
<img width="957" height="453" alt="Screenshot 2025-07-15 at 14 37 00" src="https://github.com/user-attachments/assets/95fad92f-2da7-4c26-89ed-1f4b21d84d45" />
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
- Registered some templates
- Tested Deploy VM view
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3079572051
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3075247825
@nvazquez , do we know why the behaviour has changed and this patch is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3074663128
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11207?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 3.90%. Comparing base [(`f52e058`)](https://app.codecov.io/gh/apache/cloudstack/commit/f52e05863e608f53f9e97e93fe47577b8dfe189b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d0093a6`)](https://app.codecov.io/gh/apache/cloudstack/commit/d0093a68df7280f8f1cbe8c63d005ff8c09610bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (f52e058) and HEAD (d0093a6). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (f52e058) | HEAD (d0093a6) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11207 +/- ##
=============================================
- Coverage 16.58% 3.90% -12.68%
=============================================
Files 5758 416 -5342
Lines 511733 33866 -477867
Branches 62216 6079 -56137
=============================================
- Hits 84871 1324 -83547
+ Misses 417389 32384 -385005
+ Partials 9473 158 -9315
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11207/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.90% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11207?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3078890268
code looks good @nvazquez
I see in QA that the template selected does not adhere to the os choosen, is this intended?
<img width="647" height="549" alt="Screenshot 2025-07-16 at 16 34 39" src="https://github.com/user-attachments/assets/4f65f8be-7296-41fb-a04a-3f625792e67e" />
<img width="647" height="549" alt="Screenshot 2025-07-16 at 16 34 43" src="https://github.com/user-attachments/assets/da68c83c-c133-421a-b93e-4b407ef97272" />
I am presuming this has nothing to do with this PR btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3078127028
> Yes @nvazquez , it is an obvious annoyance, I was just wondering what we overlooked that caused this regression.
I think it is caused by one of the recent changes with DeployVM.vue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3083170845
same question remains @nvazquez :
<img width="415" height="451" alt="Screenshot 2025-07-17 at 10 38 05" src="https://github.com/user-attachments/assets/35d331cf-589d-4308-b280-396f23fa57d1" />
<img width="415" height="451" alt="Screenshot 2025-07-17 at 10 38 12" src="https://github.com/user-attachments/assets/f504c737-0b38-4a03-8398-f24322d47dd6" />
The template selected does not adhere to the os chosen, is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3077950821
> Hi @DaanHoogland I don't think it an issue but I raised it as an improvement to preserve the usual template selection from previous versions (I realized when tried to deploy a VM and it complained that no template was selected). It may probably got changed with the guest OS selection refactor on the deploy VM view
Yes @nvazquez , it is an obvious annoyance, I was just wondering what we overlooked that caused this regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3079037750
Thanks @DaanHoogland I'll double check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3074632385
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3074635846
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3074730765
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11207 (QA-JID-670)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3079114574
Hi @DaanHoogland the QA server is on 4.20.0 and doesn't have the needed tables/columns for the new Guest OS selection filtering on the Deploy VM view. Can you please test on a main branch env?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3083442541
@DaanHoogland it looks intended as it hasn't changed - this PR just selects the first template from the list of templates. I've checked on the current main that changing the guest OS acts as filtering but does not select any template:
https://github.com/user-attachments/assets/c4cd78b8-c2e4-432a-acc9-b3a06b30f6c6
Maybe this could be discussed separately? Anyways I don't think that is an issue, I think the guest OS is just a filter but should not change the selected template. cc @shwstppr
@shwstppr thanks I will try exploring that solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3083343282
@nvazquez I think it will be better if preselect the first template just after the API response. Somewhere in fetchImages or fetchAllTemplates in DeployVm/DeployVnf/CreateAutoscaleGroup, etc
Otherwise, this is okay too if works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3084308199
> Maybe this could be discussed separately? Anyways I don't think that is an issue, I think the guest OS is just a filter but should not change the selected template. cc @shwstppr
sure @nvazquez , sound like a separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3079224854
> Hi @DaanHoogland the QA server is on 4.20.0 and doesn't have the needed tables/columns for the new Guest OS selection filtering on the Deploy VM view. Can you please test on a main branch env?
of course 🤦
will install a lab env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Deploy VM: Restore preselection of the first available template [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11207:
URL: https://github.com/apache/cloudstack/pull/11207#issuecomment-3077787611
Hi @DaanHoogland I don't think it an issue but I raised it as an improvement to preserve the usual template selection from previous versions (I realized when tried to deploy a VM and it complained that no template was selected). It may probably got changed with the guest OS selection refactor on the deploy VM view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org