[GitHub] spark pull request: [SPARK-11593][SQL] Replace catalyst converter ...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9565#discussion_r46245609
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala ---
    @@ -37,21 +39,36 @@ case class ScalaUDF(
     
       override def toString: String = s"UDF(${children.mkString(",")})"
     
    +  // Accessors used in genCode
    --- End diff --
    
    Why do we need manually created accessors?  All of the arguments to a case class should have public methods already created for them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org