You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2019/04/18 21:31:39 UTC
[Bug 63364] New: View Result Tree does not display embedded
resources correctly
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Bug ID: 63364
Summary: View Result Tree does not display embedded resources
correctly
Product: JMeter
Version: 5.1.1
Hardware: Macintosh
Status: NEW
Severity: regression
Priority: P2
Component: HTTP
Assignee: issues@jmeter.apache.org
Reporter: brian.tully@acquia.com
Target Milestone: JMETER_5.1.1
Created attachment 36535
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36535&action=edit
screenshot of the JMeter5 ViewResultsTree regression with embedded resources
labels
Since updating to JMeter 5, the View Results Tree listener has a regression
where it no longer displays the embedded resource request in the results.
Instead it seems to assign each embedded resource the name of its parent
request followed by an incremented number, e.g.:
https://www.google.com
- https://www.google.com-0
- https://www.google.com-1
- https://www.google.com-2
- https://www.google.com-3
Previously (JMeter 4 and lower), the View Results Tree would show the actual
request as the name for each embedded resource rather than obfuscating them.
Any idea why this is the case? Is there an option/setting to revert to previous
behavior?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Brian Tully <br...@acquia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|View Result Tree does not |View Result Tree does not
|display embedded resources |display embedded resources
|correctly if path uses |correctly
|client side JS variables |
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #11 from Brian Tully <br...@acquia.com> ---
Created attachment 36584
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36584&action=edit
JMeter 5 trunk fixed embedded resource labels
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|View Result Tree does not |When setting
|display embedded resource |"subresults.disable_renamin
|labels correctly |g=true", sub results are
| |still renamed using their
| |parent SampleLabel while
| |they shouldn't
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly if path uses client side JS variables
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|View Result Tree does not |View Result Tree does not
|display embedded resources |display embedded resources
|correctly |correctly if path uses
| |client side JS variables
CC| |p.mouawad@ubik-ingenierie.c
| |om
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Brian Tully from comment #3)
> Wow, that's really considered a feature??? Any idea why this decision was
> made? And when you say to add subresults.disable_renaming=true, am I correct
> in assuming I add that to my user.properties?
>
> Thank you!
Hello,
Yes it was considered a feature. As with any change, some people are happy ,
others are not.
If you read the bugzilla Bug 63055 referenced and the 3 referenced bugs, you'll
see why.
Yes either add it to user.properties or pass it on command line using -J
option.
If you see better solutions to initial problem, feel free to comment.
Thank you
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Brian Tully <br...@acquia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
Can you try the nightly build here:
https://builds.apache.org/job/JMeter-trunk/
Issue should be fixed now with subresults.disable_renaming=true.
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Brian Tully <br...@acquia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
CC| |brian.tully@acquia.com
Component|HTTP |Main
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |NEEDINFO
--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Tue May 14 13:14:11 2019
New Revision: 1859230
URL: http://svn.apache.org/viewvc?rev=1859230&view=rev
Log:
Bug 63364 - When setting "subresults.disable_renaming=true", sub results are
still renamed using their parent SampleLabel while they shouldn't
Bugzilla Id: 63364
Added:
jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/SamplingNamingTest.java
(with props)
Modified:
jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPAbstractImpl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPJavaImpl.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #10 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Brian Tully from comment #9)
> (In reply to Philippe Mouawad from comment #8)
> > Hello,
> > Can you try the nightly build here:
> > https://builds.apache.org/job/JMeter-trunk/
> >
> > Issue should be fixed now with subresults.disable_renaming=true.
> >
> > Thanks
>
> Hi Phillippe -
>
> Thanks again for looking into this and for the fix. Indeed things are
> working as expected in trunk when `subresults.disable_renaming=true` is
> added to user.properties.
>
> I'll upload another screenshot that shows the fix :)
>
> Thanks again!
Thanks for your feedback Brian.
Regards
Philippe M.
https://leanpub.com/master-jmeter-from-load-test-to-devops
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #15 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
It is fixed in nightly and future 5.2 not 5.1.1
Can you try with this please
https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc2/
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
This is not a bug, it's a feature :-) :
To get 4.0 behaviour , set:
subresults.disable_renaming=true
*** This bug has been marked as a duplicate of bug 63055 ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #5 from Brian Tully <br...@acquia.com> ---
I don't think this should be marked as fixed or duplicate. I am still seeing
the bug even when subresults.disable_renaming=true is set (either in
user.properties or when specified through the command line -J option) as well
as when the test plan has "Functional Test Mode" checked.
Instead of the embedded resource being named it's actual URL, or in the
previous case it being named "Sampler-[n]" (Homepage-0), all it is doing is
stripping the index off the renamed element.
So for a HTTP Sampler Request with a label of "Homepage", when looking at the
ViewResultsTree result for Homepage request, I expect to see the label of the
embedded resource to be the full path of the resource, e.g.,
https://example.com/logo.png.
Without "subresults.disable_renaming=true" specified, I see the embedded
resource result label as "Homepage-0"
With "subresults.disable_renaming=true" specified, I see the embedded resource
result label as "Homepage", i.e., the index is removed. However I was expecting
to see the actual path of the embedded resource.
Is this no longer possible?
I've attached an updated screenshot.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #6 from Brian Tully <br...@acquia.com> ---
Created attachment 36583
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36583&action=edit
with subresults.disable_renaming=true specified
updated screenshot with subresults.disable_renaming=true
Note the embedded resource is still not correctly named. It still overwrites
the label to the parent's name.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resource
labels correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Brian Tully <br...@acquia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|View Result Tree does not |View Result Tree does not
|display embedded resources |display embedded resource
|correctly |labels correctly
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Brian Tully <br...@acquia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #14 from Brian Tully <br...@acquia.com> ---
I just tried another upgrade from jmeter 4.0 to 5.1.1 after receiving an email
from this thread that this bug had been fixed.
I am still unable to revert to jmeter 4 subresource naming, even with
`subresults.disable_renaming=true` set in both my jmeter,properties and
user.properties files.
Why was this closed and why is not possible to have this behavior?
Can someone please explain why this new behavior is acceptable/preferred?
Many thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #3 from Brian Tully <br...@acquia.com> ---
Wow, that's really considered a feature??? Any idea why this decision was made?
And when you say to add subresults.disable_renaming=true, am I correct in
assuming I add that to my user.properties?
Thank you!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #16 from Brian Tully <br...@acquia.com> ---
Thanks again, Philippe! Sorry I misunderstood that it would be fixed in 5.1. I
have tested apache-jmeter-5.2-rc2 and the `subresults.disable_renaming=true`
property is working as expected :)
Cheers,
Brian
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Vladimir Sitnikov <si...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #12 from Vladimir Sitnikov <si...@gmail.com> ---
This change induces flaky CI failures:
https://travis-ci.org/vlsi/jmeter/jobs/551939913#L1036-L1040
org.apache.jmeter.protocol.http.sampler.SamplingNamingTest > testBug63364[Run
1: implementation:Java] FAILED
java.lang.AssertionError: We have at least one sample result
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
org.apache.jmeter.protocol.http.sampler.SamplingNamingTest.testBug63364(SamplingNamingTest.java:55)
What is the nature of the failure?
Could it be fixed?
Frankly speaking, I do not understand what "We have at least one sample result"
error message means.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #13 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
This is an automated email from the ASF dual-hosted git repository.
pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git
The following commit(s) were added to refs/heads/master by this push:
new 3f25fa3 Bug 63364 - When setting "subresults.disable_renaming=true",
sub results are still renamed using their parent SampleLabel while they
shouldn't
new 875b2db Merge branch 'master' of https://github.com/apache/jmeter
3f25fa3 is described below
commit 3f25fa39a324695b133b3ed1b232a6562b664f59
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Brian Tully <br...@acquia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|DUPLICATE |---
Status|RESOLVED |REOPENED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
Severity|regression |normal
Target Milestone|JMETER_5.1.1 |JMETER_5.2
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] View Result Tree does not display embedded resources
correctly
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #1 from Brian Tully <br...@acquia.com> ---
Note that the issue occurs on ALL embedded resources, including those with or
without query strings, i.e.,
- css files
- javascript files
- image files
JMeter 4's ViewResultsTree would show the actual URL path of the embedded
resource, e.g.,
https://www.google.com (parent request)
-
https://www.google.com/logos/doodles/2019/georgios-papanikolaous-136th-birthday-5142131667632128.2-l.png
(embedded resource)
Whereas now in JMeter 5.x it shows as the following:
https://www.google.com (parent request)
- https://www.google.com-0 (embedded resource)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63364] When setting "subresults.disable_renaming=true", sub
results are still renamed using their parent SampleLabel while they shouldn't
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63364
--- Comment #9 from Brian Tully <br...@acquia.com> ---
(In reply to Philippe Mouawad from comment #8)
> Hello,
> Can you try the nightly build here:
> https://builds.apache.org/job/JMeter-trunk/
>
> Issue should be fixed now with subresults.disable_renaming=true.
>
> Thanks
Hi Phillippe -
Thanks again for looking into this and for the fix. Indeed things are working
as expected in trunk when `subresults.disable_renaming=true` is added to
user.properties.
I'll upload another screenshot that shows the fix :)
Thanks again!
--
You are receiving this mail because:
You are the assignee for the bug.