You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/22 14:41:26 UTC

[GitHub] flink pull request #4573: [FLINK-7489] Remove startJobExecution and suspendE...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4573

    [FLINK-7489] Remove startJobExecution and suspendExecution from JobMasterGateway

    ## What is the purpose of the change
    
    The job lifecycle methods `startJobExecution` and `suspendExecution` should not be exposed as RPCs. Therefore, this commit removes them from the JobMasterGateway definition.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeJMRPCs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4573
    
----
commit 4b1088243a24fc3791c56eff37e1ca5fada8afbd
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-22T14:33:05Z

    [FLINK-7489] Remove startJobExecution and suspendExecution from JobMasterGateway
    
    The job lifecycle methods should not be exposed as RPCs. Therefore, this commit
    removes them from the JobMasterGateway definition.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4573: [FLINK-7489] Remove startJobExecution and suspendE...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4573: [FLINK-7489] Remove startJobExecution and suspendExecutio...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4573
  
    Failing test cases are unrelated. Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---