You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Bernd Fondermann <bf...@brainlounge.de> on 2009/04/28 10:23:57 UTC
Header stuff
Hi,
Anyone from the experienced MINA crew who'd like to comment on
http://issues.apache.org/jira/browse/VYSPER-2
Thanks,
Bernd
Re: Header stuff
Posted by Bernd Fondermann <be...@googlemail.com>.
On Tue, May 5, 2009 at 09:47, Julien Vermillard <jv...@archean.fr> wrote:
> Le Tue, 28 Apr 2009 14:04:32 +0530,
> Ashish <pa...@gmail.com> a écrit :
>
>> On Tue, Apr 28, 2009 at 1:53 PM, Bernd Fondermann
>> <bf...@brainlounge.de> wrote:
>> > Hi,
>> >
>> > Anyone from the experienced MINA crew who'd like to comment on
>> >
>> > http://issues.apache.org/jira/browse/VYSPER-2
>> >
>>
>> These are same, its my SVN client (Tortoise SVN) that hasn't updated
>> these tags. See this http://svnbook.red-bean.com/en/1.1/ch07s02.html
>>
>> I think I did put this up
>> http://mina.markmail.org/message/rpucxhis34aaktz2?q=from:Ashish+date:200904+&page=2
>>
>> Any help is appreciated, to help me fix this issue with my SVN client.
>>
>
> I start to dislike all those SVN code tags, it's just annoying to setup
> and not really useful for me. Perhaps we could drop them ?
+1 from me, but I arrived here only recently - maybe when properly
assimilated I will start to love them. But probably not.
Bernd
Re: Header stuff
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Tue, May 5, 2009 at 9:47 AM, Julien Vermillard
<jv...@archean.fr> wrote:
> I start to dislike all those SVN code tags, it's just annoying to setup
> and not really useful for me. Perhaps we could drop them ?
+1
/niklas
Re: Header stuff
Posted by Emmanuel Lecharny <el...@apache.org>.
Julien Vermillard wrote:
> Le Tue, 28 Apr 2009 14:04:32 +0530,
> Ashish <pa...@gmail.com> a écrit :
>
>
>> On Tue, Apr 28, 2009 at 1:53 PM, Bernd Fondermann
>> <bf...@brainlounge.de> wrote:
>>
>>> Hi,
>>>
>>> Anyone from the experienced MINA crew who'd like to comment on
>>>
>>> http://issues.apache.org/jira/browse/VYSPER-2
>>>
>>>
>> These are same, its my SVN client (Tortoise SVN) that hasn't updated
>> these tags. See this http://svnbook.red-bean.com/en/1.1/ch07s02.html
>>
>> I think I did put this up
>> http://mina.markmail.org/message/rpucxhis34aaktz2?q=from:Ashish+date:200904+&page=2
>>
>> Any help is appreciated, to help me fix this issue with my SVN client.
>>
>>
>
> I start to dislike all those SVN code tags, it's just annoying to setup
> and not really useful for me. Perhaps we could drop them ?
>
I never liked them. We already have everything we need on the repo.
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: Header stuff
Posted by Emmanuel Lecharny <el...@apache.org>.
Hi,
Bernd Fondermann wrote:
> <snip/>
>> I'd propose something like this:
>>
>> @author <a href="http://mina.apache.org">Apache MINA Project</a>
>>
>> At the homepage is everything one could possibly need (source,
>> documentation, and contact information). I don't know if it's better
>> to point to the subproject or not, though.
>>
>
> Maybe there have already been extensive discussions about this in the
> past, but we should give that a second thought. The website will stay,
> while mailing lists for projects (sometimes) change, as projects grow
> and MLs are forked.
>
> Essentially, I am fine with both approaches.
>
@author tags may be removed, but I find it convenient to have a tag
pointing to the original project (be it the ML or the web page). As
project might move - for instance, MINA was a part of Directory before
being a TLP, Vysper was a part of labs before being a MINA sub-project,
and may be one day a TLP...-
We just have, as a project, to decide what to do. I like the proposal to
use the http link to the project web site, instead of the dev mailing list.
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: Header stuff
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Michael Jakl wrote:
> Hi!
>
> On Tue, May 12, 2009 at 08:54, Bernd Fondermann <bf...@brainlounge.de> wrote:
>> Emmanuel Lecharny wrote:
>>> Note : We also have to use the same @author tags everywhere.
>>> SSHd uses :
>>> @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
>>>
>>> FtpServer uses :
>>> @author The Apache MINA Project (dev@mina.apache.org)
>>>
>>> MINA uses :
>>> @author The Apache MINA Project (dev@mina.apache.org)
>>>
>>> AsyncWeb still have personal author's tags like :
>>> @author <a href="mailto:adrian@ephox.com">Adrian Sutton</a>
>>>
>>> In this case, we have to do three things :
>>> 1) check that those authors are Apache committers
>>> 2) check that the code was either committed as a part of the project or
>>> as a part of an ASL 2.0 compliant project
>>> 3) if they are external (ie, ASL 2.0 compliant license project), then we
>>> have to check that the notice.txt contains the correct attribution
>> For 2) and 3), where the origin of the code is not at the ASF covered by
>> and *CLA, my understanding is that there should be either an IP grant on
>> file or a corresponding JIRA with a checked ASF-license box.
>>
>> Nevertheless, the author tags could be removed altogether, because they
>> are not a copyright (the original author retains copyright anyway, it is
>> irrevokable AFAIK) or a licensing statement.
>
> I was to support your suggestion, but after a second thought the
> author tag might have a benefit. Since everybody has the right to copy
> and use the code, it could be all over the internet, with the author
> tag it's clear where the code comes from (even if Google points to
> some class deep down the hierachy).
Actually, it already _is_ all over the internet (at least for the MINA
case :-). I intended to refer to _individual_ author tags, not the ML
author tag, which I think is should stay.
> On the other hand, removing redundancies (since it's the same
> information everywhere) is also a good thing.
>
>>> In any case, we should use the same tag formet (SSHd format ios probably
>>> more convenient, if we consider Javadoc).
>> +1
>
> dev@mina.apache.org is a mailinglist, so it *might* not be the best
> address to add without further notice (how to subscribe to it for
> example). It isn't possible to send a mail to dev@mina.apache.org
> without subscribing, is it?
It is possible, but the posting won't go through directly, it is subject
to moderation. That's how most MLs@ASF work.
> I'd propose something like this:
>
> @author <a href="http://mina.apache.org">Apache MINA Project</a>
>
> At the homepage is everything one could possibly need (source,
> documentation, and contact information). I don't know if it's better
> to point to the subproject or not, though.
Maybe there have already been extensive discussions about this in the
past, but we should give that a second thought. The website will stay,
while mailing lists for projects (sometimes) change, as projects grow
and MLs are forked.
Essentially, I am fine with both approaches.
Bernd
Re: Header stuff
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Tue, May 12, 2009 at 08:54, Bernd Fondermann <bf...@brainlounge.de> wrote:
> Emmanuel Lecharny wrote:
>> Note : We also have to use the same @author tags everywhere.
>> SSHd uses :
>> @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
>>
>> FtpServer uses :
>> @author The Apache MINA Project (dev@mina.apache.org)
>>
>> MINA uses :
>> @author The Apache MINA Project (dev@mina.apache.org)
>>
>> AsyncWeb still have personal author's tags like :
>> @author <a href="mailto:adrian@ephox.com">Adrian Sutton</a>
>>
>> In this case, we have to do three things :
>> 1) check that those authors are Apache committers
>> 2) check that the code was either committed as a part of the project or
>> as a part of an ASL 2.0 compliant project
>> 3) if they are external (ie, ASL 2.0 compliant license project), then we
>> have to check that the notice.txt contains the correct attribution
>
> For 2) and 3), where the origin of the code is not at the ASF covered by
> and *CLA, my understanding is that there should be either an IP grant on
> file or a corresponding JIRA with a checked ASF-license box.
>
> Nevertheless, the author tags could be removed altogether, because they
> are not a copyright (the original author retains copyright anyway, it is
> irrevokable AFAIK) or a licensing statement.
I was to support your suggestion, but after a second thought the
author tag might have a benefit. Since everybody has the right to copy
and use the code, it could be all over the internet, with the author
tag it's clear where the code comes from (even if Google points to
some class deep down the hierachy).
On the other hand, removing redundancies (since it's the same
information everywhere) is also a good thing.
>> In any case, we should use the same tag formet (SSHd format ios probably
>> more convenient, if we consider Javadoc).
>
> +1
dev@mina.apache.org is a mailinglist, so it *might* not be the best
address to add without further notice (how to subscribe to it for
example). It isn't possible to send a mail to dev@mina.apache.org
without subscribing, is it?
I'd propose something like this:
@author <a href="http://mina.apache.org">Apache MINA Project</a>
At the homepage is everything one could possibly need (source,
documentation, and contact information). I don't know if it's better
to point to the subproject or not, though.
Cheers,
Michael
Re: Header stuff
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Emmanuel Lecharny wrote:
> Ashish wrote:
>>> Funny enough, you don't need network to do "svn info pom.xml" ;-)
>>> so +1 for removing
>>>
>>> Maarten
>>>
>>
>> +1
>>
> I have removed all the @version from MINA, SSHD and AsyncWeb. Still have
> to remove those from FtpServer.
>
> When it will be done, I will commit if nobody complains.
>
> Note : We also have to use the same @author tags everywhere.
> SSHd uses :
> @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
>
> FtpServer uses :
> @author The Apache MINA Project (dev@mina.apache.org)
>
> MINA uses :
> @author The Apache MINA Project (dev@mina.apache.org)
>
> AsyncWeb still have personal author's tags like :
> @author <a href="mailto:adrian@ephox.com">Adrian Sutton</a>
>
> In this case, we have to do three things :
> 1) check that those authors are Apache committers
> 2) check that the code was either committed as a part of the project or
> as a part of an ASL 2.0 compliant project
> 3) if they are external (ie, ASL 2.0 compliant license project), then we
> have to check that the notice.txt contains the correct attribution
For 2) and 3), where the origin of the code is not at the ASF covered by
and *CLA, my understanding is that there should be either an IP grant on
file or a corresponding JIRA with a checked ASF-license box.
Nevertheless, the author tags could be removed altogether, because they
are not a copyright (the original author retains copyright anyway, it is
irrevokable AFAIK) or a licensing statement.
>
> In any case, we should use the same tag formet (SSHd format ios probably
> more convenient, if we consider Javadoc).
+1
Bernd
Re: It's time to plan MINA 3.0 to support AIO within jdk7
Posted by Emmanuel Lecharny <el...@apache.org>.
On Wed, May 20, 2009 at 5:43 PM, Stanley Ding <gh...@hotmail.com> wrote:
>
> Is there any plan by now?
let us release MINA 2.0 first !!! :)
But, yes, we already discussed about many things we want to add in MINA 3.0
:
- Multicast support
- NIO-2.0
- A new chain implementation
- A new buffer support
- More logs
- Dedicated protocol codec (for well known protocols)
So adding support for Java 7 and AIO might also be part of the list.
The question si how we should support different JVM version in //. We would
like to keep MINA working with Java 5 as it's still quite used (at least in
enterprises...)
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
It's time to plan MINA 3.0 to support AIO within jdk7
Posted by Stanley Ding <gh...@hotmail.com>.
Is there any plan by now?
_________________________________________________________________
Drag n’ drop—Get easy photo sharing with Windows Live™ Photos.
http://www.microsoft.com/windows/windowslive/products/photos.aspx
Re: Header stuff
Posted by Emmanuel Lecharny <el...@apache.org>.
Niklas Gustavsson wrote:
> On Tue, May 12, 2009 at 10:57 AM, Emmanuel Lecharny
> <el...@apache.org> wrote:
>
>> Np. FYI, I did it by hand (not using a script with sed) because it allowed
>> me to have a look at each header, and allowed me to see that some Javadoc
>> was needed, and such other omisions. Not sure it worth the pain in your
>> case.
>>
>
> It's probably what I'll do as well .-)
>
It's not _that_ painfull... Around one hour. There are 300 @version tags
in ftpserver, so it's a @revision removal every 12 seconds ;)
> /niklas
>
>
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: Header stuff
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Tue, May 12, 2009 at 10:57 AM, Emmanuel Lecharny
<el...@apache.org> wrote:
> Np. FYI, I did it by hand (not using a script with sed) because it allowed
> me to have a look at each header, and allowed me to see that some Javadoc
> was needed, and such other omisions. Not sure it worth the pain in your
> case.
It's probably what I'll do as well .-)
/niklas
Re: Header stuff
Posted by Emmanuel Lecharny <el...@apache.org>.
Niklas Gustavsson wrote:
> On Tue, May 12, 2009 at 5:23 AM, Emmanuel Lecharny <el...@apache.org> wrote:
>
>> Still have to remove those from FtpServer.
>>
>
> I'll take care of them if you like.
>
Np. FYI, I did it by hand (not using a script with sed) because it
allowed me to have a look at each header, and allowed me to see that
some Javadoc was needed, and such other omisions. Not sure it worth the
pain in your case.
> /niklas
>
>
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: Header stuff
Posted by Niklas Gustavsson <ni...@protocol7.com>.
On Tue, May 12, 2009 at 5:23 AM, Emmanuel Lecharny <el...@apache.org> wrote:
> Still have to remove those from FtpServer.
I'll take care of them if you like.
/niklas
Re: Header stuff
Posted by Emmanuel Lecharny <el...@apache.org>.
Ashish wrote:
>> Funny enough, you don't need network to do "svn info pom.xml" ;-)
>> so +1 for removing
>>
>> Maarten
>>
>
> +1
>
I have removed all the @version from MINA, SSHD and AsyncWeb. Still have
to remove those from FtpServer.
When it will be done, I will commit if nobody complains.
Note : We also have to use the same @author tags everywhere.
SSHd uses :
@author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
FtpServer uses :
@author The Apache MINA Project (dev@mina.apache.org)
MINA uses :
@author The Apache MINA Project (dev@mina.apache.org)
AsyncWeb still have personal author's tags like :
@author <a href="mailto:adrian@ephox.com">Adrian Sutton</a>
In this case, we have to do three things :
1) check that those authors are Apache committers
2) check that the code was either committed as a part of the project or
as a part of an ASL 2.0 compliant project
3) if they are external (ie, ASL 2.0 compliant license project), then we
have to check that the notice.txt contains the correct attribution
In any case, we should use the same tag formet (SSHd format ios probably
more convenient, if we consider Javadoc).
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: Header stuff
Posted by Ashish <pa...@gmail.com>.
> Funny enough, you don't need network to do "svn info pom.xml" ;-)
> so +1 for removing
>
> Maarten
+1
--
thanks
ashish
Re: Header stuff
Posted by Maarten Bosteels <mb...@gmail.com>.
On Wed, May 6, 2009 at 12:34 AM, Emmanuel Lecharny <el...@apache.org> wrote:
> Michael Jakl wrote:
>>
>> Hi!
>>
>> Even though I've brought this up in JIRA, I don't see any benefit from
>> these tags either - so I'd second the "drop them".
>>
>> What's the possible benefits from adding the revision and change-date
>> to a file in the first place?
>>
>
> In an ancient age, when geeks where trying to get most of their Sinclair ZX
> 81, counting CPU cycles, and using undocumented assembly instructions, it
> was useful to have those tags, as network was a luxury.
Funny enough, you don't need network to do "svn info pom.xml" ;-)
so +1 for removing
Maarten
>
> But most of you guys were probably having milk on your chin back then ;)
>
> Right now, if I want to get the version of a file, I do :
>
> elecharny@elecharny-laptop:~/apacheds/new-trunk$ svn info pom.xml
> Path: pom.xml
> Name: pom.xml
> URL:
> https://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/pom.xml
> Repository Root: https://svn.apache.org/repos/asf
> Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
> Revision: 770457
> Node Kind: file
> Schedule: normal
> Last Changed Author: elecharny
> Last Changed Rev: 577391
> Last Changed Date: 2007-09-19 19:23:55 +0200 (Wed, 19 Sep 2007)
> Text Last Updated: 2009-04-27 14:07:58 +0200 (Mon, 27 Apr 2009)
> Checksum: d4508878a4ef6be8ce3722325652eb0f
>
> If I don't have the file under SVN locally, I go on
> http://svn.apache.org/viewvc/mina, and I look at the file I'm interested in,
> to get all the needed info.
>
> Btw, I *never* do both of those operations, because it's useless...
>
> So I think those tags are injected into the source file because someone has
> some Maxtor(tm)/Seagate(tm) stocks :)
>
> --
> --
> cordialement, regards,
> Emmanuel Lécharny
> www.iktek.com
> directory.apache.org
>
>
>
Re: Header stuff
Posted by Emmanuel Lecharny <el...@apache.org>.
Michael Jakl wrote:
> Hi!
>
>
> Even though I've brought this up in JIRA, I don't see any benefit from
> these tags either - so I'd second the "drop them".
>
> What's the possible benefits from adding the revision and change-date
> to a file in the first place?
>
In an ancient age, when geeks where trying to get most of their Sinclair
ZX 81, counting CPU cycles, and using undocumented assembly
instructions, it was useful to have those tags, as network was a luxury.
But most of you guys were probably having milk on your chin back then ;)
Right now, if I want to get the version of a file, I do :
elecharny@elecharny-laptop:~/apacheds/new-trunk$ svn info pom.xml
Path: pom.xml
Name: pom.xml
URL:
https://svn.apache.org/repos/asf/directory/apacheds/trunk-with-dependencies/pom.xml
Repository Root: https://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 770457
Node Kind: file
Schedule: normal
Last Changed Author: elecharny
Last Changed Rev: 577391
Last Changed Date: 2007-09-19 19:23:55 +0200 (Wed, 19 Sep 2007)
Text Last Updated: 2009-04-27 14:07:58 +0200 (Mon, 27 Apr 2009)
Checksum: d4508878a4ef6be8ce3722325652eb0f
If I don't have the file under SVN locally, I go on
http://svn.apache.org/viewvc/mina, and I look at the file I'm interested
in, to get all the needed info.
Btw, I *never* do both of those operations, because it's useless...
So I think those tags are injected into the source file because someone
has some Maxtor(tm)/Seagate(tm) stocks :)
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: Header stuff
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Tue, May 5, 2009 at 09:47, Julien Vermillard <jv...@archean.fr> wrote:
> Le Tue, 28 Apr 2009 14:04:32 +0530,
> Ashish <pa...@gmail.com> a écrit :
>> On Tue, Apr 28, 2009 at 1:53 PM, Bernd Fondermann
>> > Anyone from the experienced MINA crew who'd like to comment on
>> >
>> > http://issues.apache.org/jira/browse/VYSPER-2
>>
>> These are same, its my SVN client (Tortoise SVN) that hasn't updated
>> these tags. See this http://svnbook.red-bean.com/en/1.1/ch07s02.html
>>
>> I think I did put this up
>> http://mina.markmail.org/message/rpucxhis34aaktz2?q=from:Ashish+date:200904+&page=2
>>
>> Any help is appreciated, to help me fix this issue with my SVN client.
>>
>
> I start to dislike all those SVN code tags, it's just annoying to setup
> and not really useful for me. Perhaps we could drop them ?
> Julien
Even though I've brought this up in JIRA, I don't see any benefit from
these tags either - so I'd second the "drop them".
What's the possible benefits from adding the revision and change-date
to a file in the first place?
Cheers,
Michael
Re: Header stuff
Posted by Julien Vermillard <jv...@archean.fr>.
Le Tue, 28 Apr 2009 14:04:32 +0530,
Ashish <pa...@gmail.com> a écrit :
> On Tue, Apr 28, 2009 at 1:53 PM, Bernd Fondermann
> <bf...@brainlounge.de> wrote:
> > Hi,
> >
> > Anyone from the experienced MINA crew who'd like to comment on
> >
> > http://issues.apache.org/jira/browse/VYSPER-2
> >
>
> These are same, its my SVN client (Tortoise SVN) that hasn't updated
> these tags. See this http://svnbook.red-bean.com/en/1.1/ch07s02.html
>
> I think I did put this up
> http://mina.markmail.org/message/rpucxhis34aaktz2?q=from:Ashish+date:200904+&page=2
>
> Any help is appreciated, to help me fix this issue with my SVN client.
>
I start to dislike all those SVN code tags, it's just annoying to setup
and not really useful for me. Perhaps we could drop them ?
Julien
Re: Header stuff
Posted by Ashish <pa...@gmail.com>.
On Tue, Apr 28, 2009 at 1:53 PM, Bernd Fondermann <bf...@brainlounge.de> wrote:
> Hi,
>
> Anyone from the experienced MINA crew who'd like to comment on
>
> http://issues.apache.org/jira/browse/VYSPER-2
>
These are same, its my SVN client (Tortoise SVN) that hasn't updated these tags.
See this http://svnbook.red-bean.com/en/1.1/ch07s02.html
I think I did put this up
http://mina.markmail.org/message/rpucxhis34aaktz2?q=from:Ashish+date:200904+&page=2
Any help is appreciated, to help me fix this issue with my SVN client.
--
thanks
ashish
Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal