You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Jarek Jarcec Cecho (Created) (JIRA)" <ji...@apache.org> on 2012/02/19 21:30:34 UTC
[jira] [Created] (SQOOP-444) Support incremental import for free
form queries
Support incremental import for free form queries
------------------------------------------------
Key: SQOOP-444
URL: https://issues.apache.org/jira/browse/SQOOP-444
Project: Sqoop
Issue Type: New Feature
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218536#comment-13218536 ]
jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------
bq. On 2012-02-28 19:39:11, Bilung Lee wrote:
bq. > Looks good to me.
Updated patch is already attached to JIRA, please feel free to commit.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5404
-----------------------------------------------------------
On 2012-02-28 14:43:52, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-28 14:43:52)
bq.
bq.
bq. Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've incorporated support for incremental import of free form queries to sqoop.
bq.
bq.
bq. This addresses bug SQOOP-444.
bq. https://issues.apache.org/jira/browse/SQOOP-444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
bq. /src/java/org/apache/sqoop/tool/ImportTool.java 1294667
bq.
bq. Diff: https://reviews.apache.org/r/3961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ant -Dhadoopversion={20,23,100} test
bq. live testing on CDH3 and Microsoft SQL Server
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217486#comment-13217486 ]
jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5344
-----------------------------------------------------------
Thanks for the patch! Two comments below.
/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11659>
This syntax ("AS alias") doesn't seem to work with Oracle. You may want to try dropping the "AS" keyword, which seems to be accepted by most major databases.
/src/java/org/apache/sqoop/tool/ImportTool.java
<https://reviews.apache.org/r/3961/#comment11648>
This replacement is specific to free form query? If so, better move this to the else block above.
- Bilung
On 2012-02-19 20:35:48, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-19 20:35:48)
bq.
bq.
bq. Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've incorporated support for incremental import of free form queries to sqoop.
bq.
bq.
bq. This addresses bug SQOOP-444.
bq. https://issues.apache.org/jira/browse/SQOOP-444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/org/apache/sqoop/tool/ImportTool.java 1245157
bq. /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157
bq.
bq. Diff: https://reviews.apache.org/r/3961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ant -Dhadoopversion={20,23,100} test
bq. live testing on CDH3 and Microsoft SQL Server
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-444) Support incremental import for free
form queries
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-444:
-------------------------------------
Attachment: SQOOP-444.patch
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218548#comment-13218548 ]
Hudson commented on SQOOP-444:
------------------------------
Integrated in Sqoop-ant-jdk-1.6 #89 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6/89/])
SQOOP-444 Support incremental import for free form queries (Revision 1294802)
Result = FAILURE
blee : http://svn.apache.org/viewvc/?view=rev&rev=1294802
Files :
* /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/ImportTool.java
* /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestIncrementalImport.java
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-444) Support incremental import for free
form queries
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-444:
-------------------------------------
Attachment: SQOOP-444.patch
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218230#comment-13218230 ]
jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/
-----------------------------------------------------------
(Updated 2012-02-28 14:43:52.891865)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
I've applied both suggestions and try it again in live testing environment against Microsoft SQL Server and MySQL.
Summary
-------
I've incorporated support for incremental import of free form queries to sqoop.
This addresses bug SQOOP-444.
https://issues.apache.org/jira/browse/SQOOP-444
Diffs (updated)
-----
/src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
/src/java/org/apache/sqoop/tool/ImportTool.java 1294667
Diff: https://reviews.apache.org/r/3961/diff
Testing
-------
ant -Dhadoopversion={20,23,100} test
live testing on CDH3 and Microsoft SQL Server
Thanks,
Jarek
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218532#comment-13218532 ]
jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5404
-----------------------------------------------------------
Ship it!
Looks good to me.
- Bilung
On 2012-02-28 14:43:52, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-28 14:43:52)
bq.
bq.
bq. Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've incorporated support for incremental import of free form queries to sqoop.
bq.
bq.
bq. This addresses bug SQOOP-444.
bq. https://issues.apache.org/jira/browse/SQOOP-444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
bq. /src/java/org/apache/sqoop/tool/ImportTool.java 1294667
bq.
bq. Diff: https://reviews.apache.org/r/3961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ant -Dhadoopversion={20,23,100} test
bq. live testing on CDH3 and Microsoft SQL Server
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-444) Support incremental import for free
form queries
Posted by "Bilung Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilung Lee updated SQOOP-444:
-----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed. Thanks, Jarcec!
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211542#comment-13211542 ]
jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/
-----------------------------------------------------------
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Summary
-------
I've incorporated support for incremental import of free form queries to sqoop.
This addresses bug SQOOP-444.
https://issues.apache.org/jira/browse/SQOOP-444
Diffs
-----
/src/java/org/apache/sqoop/tool/ImportTool.java 1245157
/src/test/com/cloudera/sqoop/TestIncrementalImport.java 1245157
Diff: https://reviews.apache.org/r/3961/diff
Testing
-------
ant -Dhadoopversion={20,23,100} test
live testing on CDH3 and Microsoft SQL Server
Thanks,
Jarek
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-444) Support incremental import for free
form queries
Posted by "Jarek Jarcec Cecho (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho updated SQOOP-444:
-------------------------------------
Status: Patch Available (was: Open)
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-444) Support incremental import for free
form queries
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218231#comment-13218231 ]
jiraposter@reviews.apache.org commented on SQOOP-444:
-----------------------------------------------------
bq. On 2012-02-27 20:02:04, Bilung Lee wrote:
bq. > /src/java/org/apache/sqoop/tool/ImportTool.java, line 183
bq. > <https://reviews.apache.org/r/3961/diff/1/?file=75912#file75912line183>
bq. >
bq. > This syntax ("AS alias") doesn't seem to work with Oracle. You may want to try dropping the "AS" keyword, which seems to be accepted by most major databases.
Thank you for checking against Oracle sir, I do not have that option at the moment.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3961/#review5344
-----------------------------------------------------------
On 2012-02-28 14:43:52, Jarek Cecho wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3961/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-28 14:43:52)
bq.
bq.
bq. Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I've incorporated support for incremental import of free form queries to sqoop.
bq.
bq.
bq. This addresses bug SQOOP-444.
bq. https://issues.apache.org/jira/browse/SQOOP-444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/test/com/cloudera/sqoop/TestIncrementalImport.java 1294667
bq. /src/java/org/apache/sqoop/tool/ImportTool.java 1294667
bq.
bq. Diff: https://reviews.apache.org/r/3961/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. ant -Dhadoopversion={20,23,100} test
bq. live testing on CDH3 and Microsoft SQL Server
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-444) Support incremental import for free
form queries
Posted by "Bilung Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilung Lee updated SQOOP-444:
-----------------------------
Fix Version/s: 1.4.2-incubating
> Support incremental import for free form queries
> ------------------------------------------------
>
> Key: SQOOP-444
> URL: https://issues.apache.org/jira/browse/SQOOP-444
> Project: Sqoop
> Issue Type: New Feature
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.4.2-incubating
>
> Attachments: SQOOP-444.patch, SQOOP-444.patch
>
>
> Would be nice if sqoop would support incremental import for free form queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira