You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/02/16 14:19:13 UTC
[GitHub] [incubator-daffodil] stevedlawrence opened a new pull request #491: Updates to make top level project
stevedlawrence opened a new pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491
- Removes all instances of "incubating"
- Removes the DISCLAIMER file and dialog in windows installer
- Updates README to match doap description
- Rewrap daffodil-cli readme so it's more readable
DAFFODIL-2470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-781583050
I definitely do not have write access to the ncsa repo, though I can login. Probably would be good to put a forwarding link in the README file. But if nobody has write access, then we can just let this fade away in time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-781574306
Checklist of external places that refer to Daffodil as incubator that will need updating:
I did a google web search for "apache daffodil (incubating)" and ran through the various returns there.
These reference the github repo, so can't be updated until the repo location/name is updated:
* scaladex - https://index.scala-lang.org/apache/incubator-daffodil/daffodil-core/3.0.0?target=_2.12
* openhub - https://www.openhub.net/p/dfdl-daffodil
This also has mentions explicitly of "apache daffodil (incubating)"
* daffodil nifi - https://opensource.ncsa.illinois.edu/bitbucket/projects/DFDL/repos/daffodil-nifi/browse
I already updated github DFDLSchemas site, and references to daffodil (incubating) within individual schemas I searched and they're not there, or if they are, they're in a historic context where I don't think we need to update them.
I verified the wikipedia page on DFDL does not mention "(incubating)" w.r.t. daffodil.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-780775502
Note to self, we also need to update the following wiki pages once the transition is complete:
* [Code Contributor Workflow](https://cwiki.apache.org/confluence/display/DAFFODIL/Code+Contributor+Workflow)
* [Release Workflow](https://cwiki.apache.org/confluence/display/DAFFODIL/Release+Workflow)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-781579155
I'm not sure we have access to the NCSA repo anymore. The maintained NiFi Daffodil repo has moved to https://github.com/TresysTechnology/nifi-daffodil. I have just now updated that repo to remove the incubating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-779965923
List of things that must be updated before this should be merged to allow things to work:
* Daffodil accepted by the ASF board as a TLP
* Repos renamed to https://github.com/apache/daffodil and https://github.com/apache/daffodil-site
* Codecov updated to work with the new repo URLs (that might be automatic with the rename)
* Sonarcloud configuration
* daffodil directory created in dist.apache.org/repos/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-782115391
I did some testing with the release candidate script this morning. I renamed my forked github repos to "daffodil" and "daffodil-site" (I reccomend others do this too), and temporarily tweaked the release candidate script to build from my fork instead of from apache and ran a dry run. Only issue was the missing ``dist/{dev,release}/daffodil`` directories. I've created those and now the release candidate scripts works with no issues, and I didn't find any instances of "incubat*". All that's left I think is for INFRA to rename the apache github repos and I'm pretty confident this change can be safely merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-780627557
I spent some time this morning building/testing the windows MSI. And I did find fix a couple issues that are now fixed in the latest fixup commit. I am much more confident that the windows MSI installer works and has no references to incubation anymore.
We'll still want to test the release candiate script once repos are renamed and this commit is merged to make sure that all works, but I think the windows aspect of that should be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #491: Updates to make top level project
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #491:
URL: https://github.com/apache/incubator-daffodil/pull/491#issuecomment-780093348
> Might need to test Windows installer before doing a real release if not already tested.
Definitely. The release candidate builder that builds the windows exe currently works by cloning the repo, so it's a bit difficult to test things that haven't been committed, without hacking a bunch of stuff together. I'm thinking that before merging, I can make some tweaks so it clones my fork and that should give some confidence that it works before merging (haven't done that). But to be 100% sure it needs to be tested after merged. Fortunately, there's a --dry-run option so that should make it pretty easy to build a test release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org