You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/31 17:03:36 UTC

[GitHub] [trafficserver] ezelkow1 opened a new pull request #7073: Expose remap config file callback

ezelkow1 opened a new pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073


   This extends the load_remap_file_callback to be load_config_file_callback.  It now takes 2 parameters so that you can specify both the parent and child file to tie to any tracked file. Also added as an API call for plugins that wish to use the functionality
   
   For plugins this only particularly makes sense to tie to remap.config.  The child/parent setup will remove all children on reload of the parent file, so a plugin would have to manually track any files other than remap (since a remap reload will cause the plugin itself to reload and re-register its config file). However this functionality may be useful in the future or as a template for when we get to more yaml rewrites and having multiple files included


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ezelkow1 merged pull request #7073: Expose remap config file callback

Posted by GitBox <gi...@apache.org>.
ezelkow1 merged pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras removed a comment on pull request #7073: Expose remap config file callback

Posted by GitBox <gi...@apache.org>.
ywkaras removed a comment on pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073#issuecomment-675179152


   [approve ci docs]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] Speedracer11 commented on pull request #7073: Expose remap config file callback

Posted by GitBox <gi...@apache.org>.
Speedracer11 commented on pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073#issuecomment-667768146


   Why are you picking on me?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ezelkow1 commented on pull request #7073: Expose remap config file callback

Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073#issuecomment-668981785


   > 
   > 
   > LGTM
   > 
   > Was there general consensus about adding this additional API?
   
   I think @sudheerv had some concerns, but @SolidWallOfCode was for it. Its also optional to use, I only added it to maxmind as an example here but it could easily be made to be optional in any plugins that were to use it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #7073: Expose remap config file callback

Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073#issuecomment-675179152


   [approve ci docs]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] Speedracer11 removed a comment on pull request #7073: Expose remap config file callback

Posted by GitBox <gi...@apache.org>.
Speedracer11 removed a comment on pull request #7073:
URL: https://github.com/apache/trafficserver/pull/7073#issuecomment-667768146


   Why are you picking on me?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org