You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "gastaldi (via GitHub)" <gi...@apache.org> on 2023/02/02 23:47:21 UTC
[GitHub] [tika] gastaldi opened a new pull request, #936: Create dependency reduced pom.xml for tika-parsers-standard-package
gastaldi opened a new pull request, #936:
URL: https://github.com/apache/tika/pull/936
`tika-parsers-standard-package` is a shaded JAR and the pom.xml keeps the transitive dependencies used to generate the shaded JAR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison merged pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison merged PR #936:
URL: https://github.com/apache/tika/pull/936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1544307329
They are not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1544300021
@gastaldi and @sberyozkin I should have foreseen the problem.
This is causing problems for users in our 2.8.0-rc1 when they try to import tika-parsers-standard-package, the transitive dependencies are not getting pulled in. Any recommendations?
cc @jnioche
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] gastaldi commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "gastaldi (via GitHub)" <gi...@apache.org>.
gastaldi commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1544372502
I see two potential solutions:
- Change the packaging to `pom` (which I don't recommend since it would break existing users)
- Avoid shading the JAR (this will transitively resolve the dependencies as expected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] gastaldi commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "gastaldi (via GitHub)" <gi...@apache.org>.
gastaldi commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1544417973
@tballison I created https://github.com/apache/tika/pull/1130 that does that. Build seems okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1544413046
Y, that works. Let me see if there are any objections on https://issues.apache.org/jira/browse/TIKA-4038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] gastaldi commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "gastaldi (via GitHub)" <gi...@apache.org>.
gastaldi commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1544304739
Aren't the binaries from the transitive dependencies are already included in this JAR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] sberyozkin commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "sberyozkin (via GitHub)" <gi...@apache.org>.
sberyozkin commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1415729852
Hi Tim, please review this PR from my colleague George
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #936: Create dependency reduced pom.xml for tika-parsers-standard-package
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #936:
URL: https://github.com/apache/tika/pull/936#issuecomment-1415953675
There are likely several other places we should do this. I've opened https://issues.apache.org/jira/browse/TIKA-3966 to track this work. Thank you @gastaldi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org