[GitHub] [beam] Abacn commented on a diff in pull request #26491: Add streaming tests to Storage Write API Python wrapper

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #26491:
URL: https://github.com/apache/beam/pull/26491#discussion_r1184117042


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2510,6 +2501,9 @@ class BeamModulePlugin implements Plugin<Project> {
           }
         }
       }
+      if (config.pythonPipelineOptions.contains("--runner=TestDataflowRunner")) {
+        pythonTask.configure {dependsOn ':sdks:python:test-suites:dataflow:initializeForDataflowJob'}

Review Comment:
   This actually won't work. `initializeForDataflowJob` exists in project like `:sdks:python:test-suites:dataflow:py310`.
   
   We can add a parameter(s) `setupTasks` to `createCrossLanguageUsingJavaExpansionTask` , and then declare here
   
   ```
   pythonTask.configure {dependsOn setupTask}
   ```
   
   and call
   ```
   createCrossLanguageUsingJavaExpansionTask(setupTask: 'initializeForDataflowJob'
   ...
   ``` 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org