You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/27 12:02:13 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request, #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
kezhenxu94 opened a new pull request, #10040:
URL: https://github.com/apache/skywalking/pull/10040
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#discussion_r1032921127
##########
oap-server/server-library/library-elasticsearch-client/src/test/java/org/apache/skywalking/library/elasticsearch/ITElasticSearchTest.java:
##########
@@ -104,6 +104,16 @@ public static Collection<Object[]> es() {
"docker.elastic.co/elasticsearch/elasticsearch-oss"))
.withEnv("plugins.security.disabled", "true")
.withStartupTimeout(java.time.Duration.ofMinutes(5))
+ },
+ {
+ "OpenSearch 2.4.0",
Review Comment:
And IT had become the longest CI task in our e2e task list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#discussion_r1032919294
##########
oap-server/server-library/library-elasticsearch-client/src/test/java/org/apache/skywalking/library/elasticsearch/ITElasticSearchTest.java:
##########
@@ -104,6 +104,16 @@ public static Collection<Object[]> es() {
"docker.elastic.co/elasticsearch/elasticsearch-oss"))
.withEnv("plugins.security.disabled", "true")
.withStartupTimeout(java.time.Duration.ofMinutes(5))
+ },
+ {
+ "OpenSearch 2.4.0",
Review Comment:
@wankai123 mentioned, we should consider to separating ElasticSearch IT from general ITs, and try to only booting ElasticSearch once per version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#discussion_r1034256489
##########
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/ElasticSearchVersion.java:
##########
@@ -43,7 +43,7 @@ private ElasticSearchVersion(final String distribution, final int major, final i
this.minor = minor;
if (distribution.equalsIgnoreCase("OpenSearch")) {
- requestFactory = new V78RequestFactory(this);
+ requestFactory = new V81RequestFactory(this);
codec = V78Codec.INSTANCE;
Review Comment:
> V81 Factory with V78 code?
`RequestFactory` is to compose the API endpoint, such as `_doc/_update/<id>`, `<index>/_update/<id>`, etc., while `Codec` is to (de)serialize the request body, so they don't have to match in version. For example, they may change the endpoint from `_doc/_update/<id>` to `/_update/<id>` but the (de)serialization of the request body is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#issuecomment-1328245673
> Error: testDocUpdate[version: OpenSearch 2.4.0](org.apache.skywalking.library.elasticsearch.ITElasticSearchTest) Time elapsed: 14.576 s <<< ERROR!
java.util.concurrent.CompletionException: java.lang.RuntimeException: {"error":"no handler found for uri [/test-index-update/_doc/an id/_update] and method [POST]"}
Caused by: java.lang.RuntimeException: {"error":"no handler found for uri [/test-index-update/_doc/an id/_update] and method [POST]"}
We seem to have an incompatible issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#issuecomment-1328690677
BTW, let's put support versions of OpenSearch on the doc. https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-storage/#opensearch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a diff in pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wankai123 commented on code in PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#discussion_r1032920582
##########
oap-server/server-library/library-elasticsearch-client/src/test/java/org/apache/skywalking/library/elasticsearch/ITElasticSearchTest.java:
##########
@@ -104,6 +104,16 @@ public static Collection<Object[]> es() {
"docker.elastic.co/elasticsearch/elasticsearch-oss"))
.withEnv("plugins.security.disabled", "true")
.withStartupTimeout(java.time.Duration.ofMinutes(5))
+ },
+ {
+ "OpenSearch 2.4.0",
Review Comment:
Yes, I found our ElasticSearch IT frequently fails recently and costs a lot of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #10040:
URL: https://github.com/apache/skywalking/pull/10040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#discussion_r1033228798
##########
oap-server/server-library/library-elasticsearch-client/src/main/java/org/apache/skywalking/library/elasticsearch/ElasticSearchVersion.java:
##########
@@ -43,7 +43,7 @@ private ElasticSearchVersion(final String distribution, final int major, final i
this.minor = minor;
if (distribution.equalsIgnoreCase("OpenSearch")) {
- requestFactory = new V78RequestFactory(this);
+ requestFactory = new V81RequestFactory(this);
codec = V78Codec.INSTANCE;
Review Comment:
V81 Factory with V78 code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org