[GitHub] [helix] pkuwm commented on pull request #1109: Stat check numChildren for listing children to exit infinite retry

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1109:
URL: https://github.com/apache/helix/pull/1109#issuecomment-647672684


   > Suggest change "TODO: remove this check once we have a better way to exit infinite retry " to "TODO: remove this check once the new Zookeeper client containing children pagination (link to the ZK issue) is released".
   
   @lei-xia Thanks for the suggestion. My thought is ZK might not have to add the feature for children pagination. But it may have other ways such as:
   - Not allowing creating a child if it is created, packet length will exceed jute.maxbuffer when listing children
   - Throw a different exception to indicate the error so zkclient could exit retry
   
   So I don't want to add a specific solution which is not yet determined in this comment. Anyway we will keep it in mind and on our TODO list. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org