You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 08:29:22 UTC
[GitHub] [airflow] tanelk opened a new pull request, #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
tanelk opened a new pull request, #24366:
URL: https://github.com/apache/airflow/pull/24366
Sending DAG timeout callbacks outside of prohibit_commit because when using standalone_dag_processor they are added to the database.
Issue reported in [slack](https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1654788028424789)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24366:
URL: https://github.com/apache/airflow/pull/24366#issuecomment-1153540522
@mhenc - can you also take a look here seems that standalone dag processor could cause problem with commit inside a "prohibit commit" guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #24366:
URL: https://github.com/apache/airflow/pull/24366#discussion_r894613222
##########
airflow/jobs/scheduler_job.py:
##########
@@ -1159,10 +1159,7 @@ def _schedule_dag_run(
msg='timed_out',
)
- # Send SLA & DAG Success/Failure Callbacks to be executed
- self._send_dag_callbacks_to_processor(dag, callback_to_execute)
Review Comment:
Yet another case where our session handling causes bugs. Our use of `@create_session` which does an expunge_all _and_ closes the session when it exits needs fixing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #24366:
URL: https://github.com/apache/airflow/pull/24366#discussion_r894611528
##########
airflow/jobs/scheduler_job.py:
##########
@@ -1159,10 +1159,7 @@ def _schedule_dag_run(
msg='timed_out',
)
- # Send SLA & DAG Success/Failure Callbacks to be executed
- self._send_dag_callbacks_to_processor(dag, callback_to_execute)
Review Comment:
Whoops, didn't this end up with the callback being sent twice before too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24366:
URL: https://github.com/apache/airflow/pull/24366#issuecomment-1152445045
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tanelk commented on a diff in pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
Posted by GitBox <gi...@apache.org>.
tanelk commented on code in PR #24366:
URL: https://github.com/apache/airflow/pull/24366#discussion_r894779661
##########
airflow/jobs/scheduler_job.py:
##########
@@ -1159,10 +1159,7 @@ def _schedule_dag_run(
msg='timed_out',
)
- # Send SLA & DAG Success/Failure Callbacks to be executed
- self._send_dag_callbacks_to_processor(dag, callback_to_execute)
Review Comment:
No, the callback is executed once, because the `callback` it returned was `None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #24366: Send DAG timeout callbacks to processor outside of prohibit_commit
Posted by GitBox <gi...@apache.org>.
ashb merged PR #24366:
URL: https://github.com/apache/airflow/pull/24366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org