You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "AnetaCadova (via GitHub)" <gi...@apache.org> on 2023/02/15 13:46:59 UTC

[GitHub] [camel-quarkus] AnetaCadova opened a new pull request, #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

AnetaCadova opened a new pull request, #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577

   FYI @jamesnetherton 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] AnetaCadova commented on a diff in pull request #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

Posted by "AnetaCadova (via GitHub)" <gi...@apache.org>.
AnetaCadova commented on code in PR #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577#discussion_r1108373870


##########
integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/GreetingBean.java:
##########
@@ -16,8 +16,13 @@
  */
 package org.apache.camel.quarkus.main;
 
+import javax.enterprise.context.ApplicationScoped;

Review Comment:
   Thanks for these suggestions. I changed these two imports as you proposed. Unfortunately, I can't build the main branch because of this error: Fatal error compiling: error: release version 17 not supported. So, I couldn't run the test locally before pushing. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577#discussion_r1107272368


##########
integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/GreetingBean.java:
##########
@@ -16,8 +16,13 @@
  */
 package org.apache.camel.quarkus.main;
 
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Named;

Review Comment:
   ```suggestion
   import jakarta.inject.Named;
   ```



##########
integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/GreetingBean.java:
##########
@@ -16,8 +16,13 @@
  */
 package org.apache.camel.quarkus.main;
 
+import javax.enterprise.context.ApplicationScoped;

Review Comment:
   ```suggestion
   import jakarta.enterprise.context.ApplicationScoped;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577#discussion_r1107678468


##########
integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/GreetingBean.java:
##########
@@ -16,8 +16,13 @@
  */
 package org.apache.camel.quarkus.main;
 
+import javax.enterprise.context.ApplicationScoped;

Review Comment:
   Oh yes indeed, that changed in main branch due to Quarkus 3 migration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577#discussion_r1108383231


##########
integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/GreetingBean.java:
##########
@@ -16,8 +16,13 @@
  */
 package org.apache.camel.quarkus.main;
 
+import javax.enterprise.context.ApplicationScoped;

Review Comment:
   Camel 4 has Java 17 as minimum version. Would you happen in a way to use lower version ?
   
   Note that [sdkman](https://sdkman.io/) is a tool that could help managing multiple java installed versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger merged pull request #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] AnetaCadova commented on a diff in pull request #4577: [backport to main] test - Define routes in YAML DSL using beans declared in Java

Posted by "AnetaCadova (via GitHub)" <gi...@apache.org>.
AnetaCadova commented on code in PR #4577:
URL: https://github.com/apache/camel-quarkus/pull/4577#discussion_r1108405994


##########
integration-tests/main-yaml/src/main/java/org/apache/camel/quarkus/main/GreetingBean.java:
##########
@@ -16,8 +16,13 @@
  */
 package org.apache.camel.quarkus.main;
 
+import javax.enterprise.context.ApplicationScoped;

Review Comment:
   I used java 11 because it's mentioned in the contributor's guide (https://github.com/apache/camel-quarkus/blob/main/docs/modules/ROOT/pages/contributor-guide/index.adoc). Java 17 fixed it for me, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org