You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/12/14 21:29:50 UTC
[GitHub] [solr] risdenk opened a new pull request, #1240: SOLR-16584 BATS test fails stopping two instances (this is just some testing)
risdenk opened a new pull request, #1240:
URL: https://github.com/apache/solr/pull/1240
https://issues.apache.org/jira/browse/SOLR-16584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1240: SOLR-16584 BATS test fails stopping two instances
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1240:
URL: https://github.com/apache/solr/pull/1240#issuecomment-1353250823
@janhoy are you happy with this? I think its an improvement. I'm thinking get it merged and then see how things look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1240: SOLR-16584 BATS test fails stopping two instances
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1240:
URL: https://github.com/apache/solr/pull/1240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1240: SOLR-16584 BATS test fails stopping two instances (this is just some testing)
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1240:
URL: https://github.com/apache/solr/pull/1240#discussion_r1049063326
##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -31,6 +31,7 @@ teardown() {
@test "SOLR11740 check f" {
solr start
solr start -p 7574
+ sleep 5
Review Comment:
You can assert solr is running, which will return status 0 immediately if solr is running, else wait.
```suggestion
bin/solr assert --started http://localhost:8983/solr --timeout 5000
bin/solr assert --started http://localhost:7574/solr --timeout 5000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1240: SOLR-16584 BATS test fails stopping two instances (this is just some testing)
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1240:
URL: https://github.com/apache/solr/pull/1240#discussion_r1049063326
##########
solr/packaging/test/test_start_solr.bats:
##########
@@ -31,6 +31,7 @@ teardown() {
@test "SOLR11740 check f" {
solr start
solr start -p 7574
+ sleep 5
Review Comment:
You can assert solr is running, which will return status 0 immediately if solr is running, else wait.
```suggestion
solr assert --started http://localhost:8983/solr --timeout 5000
solr assert --started http://localhost:7574/solr --timeout 5000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org