You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/22 13:39:26 UTC
[GitHub] cloud-fan edited a comment on issue #23010: [SPARK-26012][SQL]Null
and '' values should not cause dynamic partition failure of string types
cloud-fan edited a comment on issue #23010: [SPARK-26012][SQL]Null and '' values should not cause dynamic partition failure of string types
URL: https://github.com/apache/spark/pull/23010#issuecomment-466398924
ah good catch!
I think the right fix is, in your rule `UpdateEmptyValueOfPartitionToNull`, we handle `CreateDataSourceTableAsSelectCommand` as well. Then we don't need to touch `writeAndRead` at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org