You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "rizaon (via GitHub)" <gi...@apache.org> on 2023/04/05 21:05:50 UTC
[GitHub] [thrift] rizaon opened a new pull request, #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
rizaon opened a new pull request, #2772:
URL: https://github.com/apache/thrift/pull/2772
<!-- Explain the changes in the pull request below: -->
Client: java
TByteBuffer.java does not allow passing custom TConfiguration into constructor
https://github.com/apache/thrift/blob/66aac4465926404c2bb0c450e80fac2c2824c04c/lib/java/src/main/java/org/apache/thrift/transport/TByteBuffer.java#L18-L22
Default TConfiguration limit message size is 100MB maximum. TByteBuffer initialization will fail with "MaxMessageSize reached" error for ByteBuffer longer than 100MB.
```
org.apache.thrift.transport.TTransportException: MaxMessageSize reached
at org.apache.thrift.transport.TEndpointTransport.resetConsumedMessageSize(TEndpointTransport.java:58)
at org.apache.thrift.transport.TEndpointTransport.updateKnownMessageSize(TEndpointTransport.java:71)
at org.apache.thrift.transport.TByteBuffer.<init>(TByteBuffer.java:24)
```
This PR adds one more constructor in TByteBuffer.java that accept custom TConfiguration.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] rizaon commented on a diff in pull request #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
Posted by "rizaon (via GitHub)" <gi...@apache.org>.
rizaon commented on code in PR #2772:
URL: https://github.com/apache/thrift/pull/2772#discussion_r1159033755
##########
lib/java/src/test/java/org/apache/thrift/transport/TestTByteBuffer.java:
##########
@@ -39,4 +41,29 @@ public void testOverflow() throws Exception {
() -> byteBuffer.write("Hello World".getBytes(StandardCharsets.UTF_8)));
assertEquals("Not enough room in output buffer", e.getMessage());
}
+
+ @Test
+ public void testSmallTConfiguration() throws Exception {
+ // Test that TByteBuffer init fail with small max message size.
+ final TConfiguration configSmall =
+ new TConfiguration(
+ 4, TConfiguration.DEFAULT_MAX_FRAME_SIZE, TConfiguration.DEFAULT_RECURSION_DEPTH);
Review Comment:
I think there is checkstyle built in the gradle script. This pass `gradle :spotlessApply`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy merged pull request #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy merged PR #2772:
URL: https://github.com/apache/thrift/pull/2772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on a diff in pull request #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on code in PR #2772:
URL: https://github.com/apache/thrift/pull/2772#discussion_r1159030073
##########
lib/java/src/test/java/org/apache/thrift/transport/TestTByteBuffer.java:
##########
@@ -39,4 +41,29 @@ public void testOverflow() throws Exception {
() -> byteBuffer.write("Hello World".getBytes(StandardCharsets.UTF_8)));
assertEquals("Not enough room in output buffer", e.getMessage());
}
+
+ @Test
+ public void testSmallTConfiguration() throws Exception {
+ // Test that TByteBuffer init fail with small max message size.
+ final TConfiguration configSmall =
+ new TConfiguration(
+ 4, TConfiguration.DEFAULT_MAX_FRAME_SIZE, TConfiguration.DEFAULT_RECURSION_DEPTH);
Review Comment:
I'm not sure if we have a java style guide or something but this style looks weird to me, but that might be just me (as I don't write java nowadays).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] rizaon commented on pull request #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
Posted by "rizaon (via GitHub)" <gi...@apache.org>.
rizaon commented on PR #2772:
URL: https://github.com/apache/thrift/pull/2772#issuecomment-1499497122
Thank you for accepting this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] fishy commented on pull request #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2772:
URL: https://github.com/apache/thrift/pull/2772#issuecomment-1499337710
> @fishy The check failure in Build / lib-go (1.19) does not seem to be related with this patch. Can we have another try running the checks?
that's unrelated and I already fixed it, you can either rebase your branch on top of latest master to retry, or just ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] rizaon commented on pull request #2772: THRIFT-5696: Allow custom TConfiguration for TByteBuffer.java
Posted by "rizaon (via GitHub)" <gi...@apache.org>.
rizaon commented on PR #2772:
URL: https://github.com/apache/thrift/pull/2772#issuecomment-1499312792
@fishy The check failure in Build / lib-go (1.19) does not seem to be related with this patch.
Can we have another try running the checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org