[GitHub] [arrow-rs] bjchambers commented on pull request #521: Change `nullif` to support arbitrary arrays

[GitBox <gi...@apache.org>]

bjchambers commented on pull request #521:
URL: https://github.com/apache/arrow-rs/pull/521#issuecomment-1001648627


   I've lost the thread on this one. I have a version of this checked in and used in some internal code, so I don't *need* this to go in. At the same time, it seems like supporting `nullif` on arbitrary arrays would be beneficial. I'm more than happy to close this and wait for a "better" implementation...  seems like it may be acceptable to check-in something since it improves upon the current state (`nullif` limited to primitive arrays) and then improve the implementation if/when performance is a problem and/or an improved implementation is available.
   
   I'm happy to go either way with this -- if we'd like to move forward I have some additional proptests and such that found a bug or two in the implementation that I'll add, just to make this complete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org