[GitHub] [arrow-rs] martin-g commented on a change in pull request #888: add support for f16

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #888:
URL: https://github.com/apache/arrow-rs/pull/888#discussion_r742671364



##########
File path: arrow/src/array/data.rs
##########
@@ -88,6 +89,19 @@ pub(crate) fn new_buffers(data_type: &DataType, capacity: usize) -> [MutableBuff
             MutableBuffer::new(capacity * mem::size_of::<i64>()),
             empty_buffer,
         ],
+        DataType::Float16 => {
+            #[cfg(feature = "f16")]
+            {
+                [
+                    MutableBuffer::new(capacity * mem::size_of::<f16>()),
+                    empty_buffer,
+                ]
+            }
+            #[cfg(not(feature = "f16"))]
+            {
+                unimplemented!()

Review comment:
       `unimplemented!("Float16 datatype not supported")` as in the other places




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org