You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/05 08:49:20 UTC
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #11775: [fix][API]fix task types sequence
Tianqi-Dotes commented on code in PR #11775:
URL: https://github.com/apache/dolphinscheduler/pull/11775#discussion_r962651336
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/TaskTypeConfiguration.java:
##########
@@ -48,18 +49,16 @@ public class TaskTypeConfiguration {
private List<String> machineLearning;
- public Set<FavTaskDto> getDefaultTaskTypes() {
- Set<FavTaskDto> defaultTaskTypes = new HashSet<>();
- if (defaultTaskTypes.size() <= 0) {
- universal.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_UNIVERSAL)));
- cloud.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_CLOUD)));
- logic.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_LOGIC)));
- dataIntegration.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_DATA_INTEGRATION)));
- dataQuality.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_DATA_QUALITY)));
- machineLearning.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_MACHINE_LEARNING)));
- other.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_OTHER)));
+ public List<FavTaskDto> getDefaultTaskTypes() {
+ List<FavTaskDto> defaultTaskTypes = new ArrayList<>();
- }
+ universal.forEach(task -> defaultTaskTypes.add(new FavTaskDto(task, false, Constants.TYPE_UNIVERSAL)));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org