You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/11 12:21:47 UTC
[GitHub] [skywalking-nginx-lua] mrproliu opened a new pull request #33: fix
wrong context carrier endpoint data
mrproliu opened a new pull request #33: fix wrong context carrier endpoint data
URL: https://github.com/apache/skywalking-nginx-lua/pull/33
Currently, when the Nginx tracing context has a reference context, it will send an error header to the downstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-nginx-lua] wu-sheng merged pull request #33: fix wrong
context carrier endpoint data
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #33: fix wrong context carrier endpoint data
URL: https://github.com/apache/skywalking-nginx-lua/pull/33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-nginx-lua] wu-sheng commented on a change in pull
request #33: fix wrong context carrier endpoint data
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #33: fix wrong context carrier endpoint data
URL: https://github.com/apache/skywalking-nginx-lua/pull/33#discussion_r407059137
##########
File path: lib/skywalking/span.lua
##########
@@ -102,11 +102,7 @@ function _M.createExitSpan(operationName, context, parent, peer, contextCarrier)
local firstSpan = context.internal.first_span
local parentEndpointName
- if context.internal.first_ref then
- parentEndpointName = context.internal.first_ref.entry_endpoint_name
- else
- parentEndpointName = firstSpan.operation_name
- end
+ parentEndpointName = firstSpan.operation_name
Review comment:
Do you remove `first_ref` variable? I think it is useless today. @mrproliu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-nginx-lua] mrproliu commented on a change in pull
request #33: fix wrong context carrier endpoint data
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #33: fix wrong context carrier endpoint data
URL: https://github.com/apache/skywalking-nginx-lua/pull/33#discussion_r407060354
##########
File path: lib/skywalking/span.lua
##########
@@ -102,11 +102,7 @@ function _M.createExitSpan(operationName, context, parent, peer, contextCarrier)
local firstSpan = context.internal.first_span
local parentEndpointName
- if context.internal.first_ref then
- parentEndpointName = context.internal.first_ref.entry_endpoint_name
- else
- parentEndpointName = firstSpan.operation_name
- end
+ parentEndpointName = firstSpan.operation_name
Review comment:
That's true, I will make a new PR to remove this variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services