You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/09/16 05:59:28 UTC
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3367:
agent support custom properties.
wu-sheng commented on a change in pull request #3367: agent support custom properties.
URL: https://github.com/apache/skywalking/pull/3367#discussion_r324517297
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -110,6 +110,13 @@
* Limit the length of the operationName to prevent errors when inserting elasticsearch
**/
public static int OPERATION_NAME_THRESHOLD = 500;
+
+ /*
+ * service properties
+ * e.g.
+ * agent.properties[org]=apache
+ */
+ public static Map<String, String> PROPERTIES = new HashMap<String, String>();
Review comment:
The properties should be instance level, according to your latest update. This should be named as `INSTANCE_PROPERTIES`, and documents is required to update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services