You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2011/11/18 00:41:52 UTC

[jira] [Commented] (ZOOKEEPER-1303) Observer LearnerHandlers are not removed from Leader collection.

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152464#comment-13152464 ] 

Hadoop QA commented on ZOOKEEPER-1303:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12504139/removeObservingLearners.diff
  against trunk revision 1202557.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/793//console

This message is automatically generated.
                
> Observer LearnerHandlers are not removed from Leader collection.
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1303
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1303
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.4
>            Reporter: Ashish Mishra
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: removeObservingLearners.diff
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The Leader.removeLearnerHandler() call removes handlers from the forwardingFollowers and learners sets, but not from observingLearners.  This will cause a leak if observers are repeatedly connected and disconnected from the ensemble.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira