[GitHub] [arrow] zeroshade commented on a diff in pull request #34967: GH-34966: [Go] Add InsertField and FieldIndex to Schema object

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #34967:
URL: https://github.com/apache/arrow/pull/34967#discussion_r1163026455


##########
go/arrow/schema.go:
##########
@@ -197,6 +197,16 @@ func (sc *Schema) FieldIndices(n string) []int {
 	return sc.index[n]
 }
 
+// FieldIndex return index of the unique field with the given name.

Review Comment:
   typo: `returns the index`
   
   Also, is there a reason to have this in addition to the existing `FieldIndices` method? A consumer could just do the same length check and use index 0 themselves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org