You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2019/02/20 11:29:04 UTC

[GitHub] JiriOndrusek commented on issue #513: [CXF-7977] Osgi quickstasrt (keycloak-cxf) fails with wrong protocol

JiriOndrusek commented on issue #513: [CXF-7977] Osgi quickstasrt (keycloak-cxf) fails with wrong protocol 
URL: https://github.com/apache/cxf/pull/513#issuecomment-465536683
 
 
   @ffang May I ask for a review? I'm not sure whether condition "tlsServerParameters.getClientAuthentication() != null" is strong enough. Whether it is possible to want https without this parameter.Code from [1] seems that having it is the only way how to force undertow to use ssl. (other option is to check whether at least one property is not null - but it is ugly and error causing solution)
   
   Thank you in advance,
   Jiri
   
   
   [1] https://github.com/apache/cxf/blob/master/rt/transports/http-undertow/src/main/java/org/apache/cxf/transport/http_undertow/UndertowHTTPServerEngine.java#L277

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services