You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/04/24 20:50:03 UTC
[GitHub] [accumulo] dlmarion opened a new pull request, #3335: Set the TabletHostingGoal during tablet merge
dlmarion opened a new pull request, #3335:
URL: https://github.com/apache/accumulo/pull/3335
Closes #3307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #3335: Set the TabletHostingGoal during tablet merge
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3335:
URL: https://github.com/apache/accumulo/pull/3335#discussion_r1175825909
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -756,9 +761,22 @@ private void mergeMetadataRecords(MergeInfo info) throws AccumuloException {
} else if (ServerColumnFamily.DIRECTORY_COLUMN.hasColumns(key)) {
var allVolumesDir = new AllVolumesDirectory(range.tableId(), value.toString());
bw.addMutation(manager.getContext().getAmple().createDeleteMutation(allVolumesDir));
+ } else if (HostingColumnFamily.GOAL_COLUMN.hasColumns(key)) {
+ TabletHostingGoal thisGoal = TabletHostingGoalUtil.fromValue(value);
+ goals.add(thisGoal);
}
}
+ // Set the TabletHostingGoal for this tablet based on the goals of the other tablets in
Review Comment:
Could move all of this logic down past the next loop AND get the hosting goal of the last tablet in the next scan loop. Then the decision would be based on all tablets instead of every tablet but the last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3335: Set the TabletHostingGoal during tablet merge
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #3335:
URL: https://github.com/apache/accumulo/pull/3335#discussion_r1176406462
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -756,9 +761,22 @@ private void mergeMetadataRecords(MergeInfo info) throws AccumuloException {
} else if (ServerColumnFamily.DIRECTORY_COLUMN.hasColumns(key)) {
var allVolumesDir = new AllVolumesDirectory(range.tableId(), value.toString());
bw.addMutation(manager.getContext().getAmple().createDeleteMutation(allVolumesDir));
+ } else if (HostingColumnFamily.GOAL_COLUMN.hasColumns(key)) {
+ TabletHostingGoal thisGoal = TabletHostingGoalUtil.fromValue(value);
+ goals.add(thisGoal);
}
}
+ // Set the TabletHostingGoal for this tablet based on the goals of the other tablets in
Review Comment:
Updated in d3975ec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #3335: Set the TabletHostingGoal during tablet merge
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #3335:
URL: https://github.com/apache/accumulo/pull/3335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org