[jira] [Commented] (KARAF-4330) Instance script doesn't return correct PID number if root instance is started two times

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144339#comment-15144339 ] 

ASF GitHub Bot commented on KARAF-4330:
---------------------------------------

GitHub user oscerd opened a pull request:

    https://github.com/apache/karaf/pull/144

    [KARAF-4330] Instance script doesn't return correct PID number if roo…

    …t instance is started two times
    
    I submit this little PR for review. In case we start root instance two times, the instance script trace the second instance PID even if the process is hanging because of the first instance.
    
    If it's ok for everyone I'll push this on master, 4.0.x and perhaps on 3.0.x.
    
    I'm waiting for your feedback :-) Thanks.
    
    Andrea

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oscerd/karaf KARAF-4330

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit 20d8a57f11b08eed4ac9a78c09915616d74473a2
Author: Andrea Cosentino <an...@gmail.com>
Date:   2016-02-12T09:59:05Z

    [KARAF-4330] Instance script doesn't return correct PID number if root instance is started two times

----


> Instance script doesn't return correct PID number if root instance is started two times
> ---------------------------------------------------------------------------------------
>
>                 Key: KARAF-4330
>                 URL: https://issues.apache.org/jira/browse/KARAF-4330
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-core
>    Affects Versions: 3.0.5, 4.0.4
>            Reporter: Andrea Cosentino
>            Assignee: Andrea Cosentino
>            Priority: Minor
>
> Use case:
> - Run a first Karaf root instance 
> - Check the PID with instance script
> - Run a second Karaf root instance, the script will hang as expected
> - Check the PID with the instance script. The PID will be the one from the second instance even if it's not started correctly and it's hanging.
> - Kill the second instance
> - Check the PID with the instance script. The PID is now 0 and the status is stopped, but we have the first instance currently running.
> This is not a normal workflow, I see. Starting two times the root instance or two instances with the same instance name is not correct, but anyway it's something we should consider to manage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)