[GitHub] [arrow] wesm commented on a change in pull request #7272: ARROW-8314: [Python] Add a Table.select method to select a subset of columns

[GitBox <gi...@apache.org>]

wesm commented on a change in pull request #7272:
URL: https://github.com/apache/arrow/pull/7272#discussion_r453944356



##########
File path: cpp/src/arrow/table.cc
##########
@@ -362,6 +362,23 @@ Result<std::shared_ptr<Table>> Table::RenameColumns(
   return Table::Make(::arrow::schema(std::move(fields)), std::move(columns), num_rows());
 }
 
+Result<std::shared_ptr<Table>> Table::SelectColumns(
+    const std::vector<int>& indices) const {
+  int n = static_cast<int>(indices.size());
+
+  std::vector<std::shared_ptr<ChunkedArray>> columns(n);
+  std::vector<std::shared_ptr<Field>> fields(n);
+  for (int i = 0; i < n; i++) {
+    int pos = indices[i];

Review comment:
       If this is returning `Result` anyway we might as well boundscheck the indices, thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org