You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/18 17:20:51 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6601: [AIRFLOW-6010] Do not import airflow settings directly. Depends on [AIRFLOW-6009]

ashb commented on a change in pull request #6601: [AIRFLOW-6010] Do not import airflow settings directly. Depends on [AIRFLOW-6009]
URL: https://github.com/apache/airflow/pull/6601#discussion_r347507567
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -70,10 +70,18 @@
 
 LOG = LoggingMixin().log
 
-DAGS_FOLDER = settings.DAGS_FOLDER
 
-if "BUILDING_AIRFLOW_DOCS" in os.environ:
-    DAGS_FOLDER = '[AIRFLOW_HOME]/dags'
+def get_dags_folder():
+    """Retrieves DAGS_FOLDER to use."""
+    from airflow.settings import DAGS_FOLDER
 
 Review comment:
   I feel that since this fn is called at the module level this code is identical to what was there before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services