You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:11:14 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #16194: [FLINK-21952] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
gaoyunhaii opened a new pull request #16194:
URL: https://github.com/apache/flink/pull/16194
## What is the purpose of the change
This PR fixes the bug that wrongly wrap the Netty connection reset exception as `LocalTransportException`.
## Brief change log
- 6252cb5c4d9b3adfe3dcdba7d90aa7d1dc62575f fixes the bug.
## Verifying this change
This change could be verified via the added UT.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #16194: [FLINK-21952][network] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #16194:
URL: https://github.com/apache/flink/pull/16194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16194: [FLINK-21952] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16194:
URL: https://github.com/apache/flink/pull/16194#issuecomment-863874885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16194: [FLINK-21952][network] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16194:
URL: https://github.com/apache/flink/pull/16194#issuecomment-864130044
Very thanks @pnowojski for the review~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #16194: [FLINK-21952][network] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #16194:
URL: https://github.com/apache/flink/pull/16194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16194: [FLINK-21952] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16194:
URL: https://github.com/apache/flink/pull/16194#issuecomment-863899151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16194: [FLINK-21952][network] Make all the "Connection reset by peer" exception wrapped as RemoteTransportException
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16194:
URL: https://github.com/apache/flink/pull/16194#issuecomment-863874885
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6252cb5c4d9b3adfe3dcdba7d90aa7d1dc62575f (Thu Sep 23 17:25:47 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org